Problem/Motivation

hook_help function missing in .module file

CommentFileSizeAuthor
#5 hook_help.png72.02 KBannmarysruthy

Issue fork button_formatter-3344164

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !1

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Create MR for the issue.
Please review.
Thanks.

annmarysruthy’s picture

annmarysruthy commented
Assigned: Unassigned » annmarysruthy
annmarysruthy’s picture

annmarysruthy commented
Assigned: annmarysruthy » Unassigned
StatusFileSize
new hook_help.png72.02 KB

Reviewed MR !1 and hook_help() is implemented.

annmarysruthy’s picture

annmarysruthy commented
Status: Needs review » Reviewed & tested by the community
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

Showing just the first sentence used in the project page is not sufficient for this MR/patch to be considered.

adminazhar opened merge request !2

adminazhar made their first commit to this issue’s fork.

admin@azhark.com’s picture

admin@azhark.com commented
Status: Needs work » Needs review

Create new merge request !2 based on the feedback by @apaderno
Kindly review

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I would use The Button Formatter module. For the rest, it seems a more helpful sentence.

admin@azhark.com’s picture

admin@azhark.com commented

@apaderno Corrected as per suggestion.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
m.abdulqader’s picture

m.abdulqader commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The MR has not been yet merged. It was a commit behind the branch, so it was automatically rejected.

apaderno changed the visibility of the branch 8.x-1.x to hidden.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.