GitLab CI reports PHP_CodeSniffer warnings/errors which should be fixed.

CommentFileSizeAuthor
#2 3344155-2.patch5.04 KBsamitk

Issue fork group_action-3344155

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3344155-2.patch5.04 KB

Above error/warnings are fixed.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the patch #2 and it working fine. Attaching the screenshot for reference.
Moving it to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Issue tags: -Coding standards Phpcs, -Phpcs Drupal coding standard issue

The only issue tag for coding standards is Coding standards. There is no need to use tags like Coding standards Phpcs, or Phpcs Drupal coding standard issue.

mxh’s picture

mxh commented
Status: Reviewed & tested by the community » Needs work

Still not using correct Drupal coding standards. Example:

+  /**
+   * The decodeValues function.
+   */
   protected function decodeValues(string $values_string): array {
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Needs merge request

Since patches are no longer tested, a merge request is needed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

avpaderno opened merge request !4

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fix the issues reported by phpcs » Fix the issues reported by PHP_CodeSniffer
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
Issue tags: -Needs merge request

GitLab CI no longer reports PHP_CodeSniffer errors/warnings.

mxh’s picture

mxh commented
Assigned: avpaderno » Unassigned
Status: Needs review » Fixed

PHPCS complaints are indeed fixed now, thanks.

  • mxh committed a55ff025 on 1.0.x authored by avpaderno 
    Issue #3344155: Fix the issues reported by PHP_CodeSniffer

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.