CommentFileSizeAuthor
#3 patch applied.png24.38 KBannmarysruthy
#2 3343650-2.patch280 bytesgayatri chahar

Issue fork trim-3343650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gayatri chahar created an issue. See original summary.

gayatri chahar’s picture

gayatri chahar commented
Assigned: gayatri chahar » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3343650-2.patch280 bytes

Patch created.
Please review it

annmarysruthy’s picture

annmarysruthy commented
Issue summary: View changes
StatusFileSize
new patch applied.png24.38 KB

Reviewed patch #2. patch applied cleanly and core is removed.

annmarysruthy’s picture

annmarysruthy commented
Status: Needs review » Reviewed & tested by the community

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !4

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and why the change is proposed.

-core: 8.x
 core_version_requirement: ^8 || ^9

Removing core is not necessary, in this case, since core_version_requirement is not changed. It is also the wrong change for a branch that probably should be used from sites to upgrade from Drupal 8 to Drupal 9.

mlncn’s picture

mlncn commented
Status: Needs work » Fixed

We do drop the old core: 8.x for the Drupal 10 compatible release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.