Problem/Motivation

  • Add a REST API and modify the SPA source code as well.
CommentFileSizeAuthor
#13 スクリーンショット 2023-02-24 12.06.27.png97.59 KByas
#13 スクリーンショット 2023-02-24 12.06.22.png105.68 KByas

Issue fork cloud-3343582

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1604

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 63ed012d on 5.x authored by Ryo Yamashita 
    Issue #3343582 by Ryo Yamashita, yas: Add the function to preview...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Can you please create the patch for the branch 4.x? 4.x and 5.x branch are identical but they look different by #3342633: Add the function to create OpenStack stack in the SPA. Can you double-check it? Thanks

Ryo Yamashita opened merge request !1607

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed the patch for the 4.x branch. Thanks.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs review » Needs work

Ryo Yamashita closed merge request !1607

Ryo Yamashita opened merge request !1608

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Note: The #3343582-add-function-to-preview-openstack-stack-for-4.x branch was created from the 4.x branch and has the #3343582 diff patch applied. However, GitLab recognizes it as a patch to merge to the 5.x branch, so a merge error is occurring. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new スクリーンショット 2023-02-24 12.06.22.png105.68 KB
new スクリーンショット 2023-02-24 12.06.27.png97.59 KB

@ryo-yamashita

Thank you for the update. You can switch the branch to 4.x. See the screenshots. I changed it from 5.x to 4.x. However, it looks not mergeable. Can you double-check the patch?

06.22.png

06.27.png

Thanks

ryo yamashita’s picture

ryo yamashita commented

@yas

Thank you for your advice. I will rebase this patch for 4.x.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. It still looks having an issue about the merge error. Can you please double-check it? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the patch for 4.x. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll try to merge the patch. Thanks!

  • yas committed 040d2c96 on 4.x authored by Ryo Yamashita 
    Issue #3343582 by Ryo Yamashita, yas: Add the function to preview...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.