Problem/Motivation

See the change record here https://www.drupal.org/node/3207439 .

At the same time I believe that this could be classified as a bug because there is no need to encode valid MIME type returned by the MIME guesser service in the first place.

Proposed resolution

Use MIME type from MIME guesser service without encoding.

Remaining tasks

  • Patch - done
  • Review
  • Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 3343581-5.patch1000 bytesomkar_yewale
#2 file_downloader-3343581-2.patch633 bytesrosk0

Comments

RoSk0 created an issue. See original summary.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: rosk0 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new file_downloader-3343581-2.patch633 bytes
rassoni’s picture

rassoni commented

Deprecated code should cover in D10 or D9 compatibility issues. Instead of removing it . we can use
\Symfony\Component\Mime\Header\UnstructuredHeader.

 Call to deprecated method mimeHeaderEncode() of class         
         Drupal\Component\Utility\Unicode:                             
         in drupal:9.2.0 and is removed from drupal:10.0.0. Use        
           \Symfony\Component\Mime\Header\UnstructuredHeader instead.
omkar_yewale’s picture

omkar_yewale commented
Assigned: Unassigned » omkar_yewale
omkar_yewale’s picture

omkar_yewale commented
Assigned: omkar_yewale » Unassigned
StatusFileSize
new 3343581-5.patch1000 bytes

Here is the updated patch. Please take a look.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Reviewed & tested by the community

Please read the issue description

> At the same time I believe that this could be classified as a bug because there is no need to encode valid MIME type returned by the MIME guesser service in the first place.

This is not specifically about deprecation. There is no need to do encoding here - look at what core does https://git.drupalcode.org/project/drupal/-/blob/10.1.0/core/modules/fil... I do not see a reason why this module would need to do anything different.

I believe the correct approach is from the original patch to remove the encoding. RTBC based on patch in #2

sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
commented
Status: Reviewed & tested by the community » Fixed

This was committed in https://git.drupalcode.org/project/file_downloader/-/commit/c7069f5e3795...

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.