Problem/Motivation

Getting following error.

FILE: /var/www/html/modules/contrib/map_widget/tests/src/FunctionalJavascript/MapWidgetAjaxTest.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
103 | ERROR | [x] Expected one space after the comma, 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

Time: 4.13 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/map_widget/

Proposed resolution

Above error/warnings need to be fixed.

CommentFileSizeAuthor
#2 3343044-2.patch891 bytessamitk

Issue fork map_widget-3343044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3343044-2.patch891 bytes

Above error is fixed.

rohan-sinha’s picture

rohan-sinha commented

Reviewed Patch on #2, working fine can be merged .

Charchil Khandelwal made their first commit to this issue’s fork.

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: Unassigned » charchil khandelwal

Charchil Khandelwal opened merge request !1

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: charchil khandelwal » Unassigned

Created MR !1 for easy preview and commenting.
RTBC +1.

Thanks.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Issue tags: -Coding standards Phpcs, -Phpcs Drupal coding standard issue
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.