Problem/Motivation

  • Save user_roles to OpenStack Project

Issue fork cloud-3343034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1597

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
rohan-sinha’s picture

rohan-sinha commented

Reviewed the MR on #2, functionality working fine.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. Can you fix the following coding standard violations?

FILE: ...ice_providers/openstack/src/Entity/OpenStackProjectInterface.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     3
 81 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 82 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
----------------------------------------------------------------------

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've fixed it. Please take a look again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@rckstr_rohan

Thank you for your review.

@xiaohua-guan

Thank you for your update. It looks good, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 87654e9a on 5.x authored by Xiaohua Guan 
    Issue #3343034 by Xiaohua Guan, yas, rckstr_rohan: Save user_roles to...

  • yas committed de345a40 on 4.x authored by Xiaohua Guan 
    Issue #3343034 by Xiaohua Guan, yas, rckstr_rohan: Save user_roles to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.