Problem/Motivation

Important testing was removed from core in #3293813: Move RDF-related tests to RDF module: NodeDisplayConfigurableTest, node_display_configurable_test.info. This testing (that I spent quite a while writing) is/was an important part of the initiative #2353867: [META] Expose Title and other base fields in Manage Display.

Proposed resolution

Bring the testing back.

Remaining tasks

Fix test

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3342700

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AdamPS created an issue. See original summary.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone made their first commit to this issue’s fork.

quietone opened merge request !8937

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs work

I restored the test.

pooja_sharma made their first commit to this issue’s fork.

pooja_sharma’s picture

pooja_sharma commented
Status: Needs work » Needs review

Observed test failures, found there are some assert() test case failures , addressed those errors, pipeline passed.

As remaining task - Fix test addressed , I'm gonna move it from the remaining tasks section to the proposed resolution

MR is mergeable now, PLease review , moving to NR.

pooja_sharma’s picture

pooja_sharma commented
Issue summary: View changes
jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Status: Needs review » Reviewed & tested by the community

This makes sense to me. There's no obvious dependency on rdf in the test, and if there's a hidden dependency someone needs to explain it.

What I wonder about is whether the explicit mark we're asserting is somehow influenced by rdf, but I don't see how it can even be installed in the test: NodeTestBase does't install it and none of the core themes tested use it.

smustgrave’s picture

smustgrave commented
Issue summary: View changes

Checking the ticket were the test was moved to RDF appears moving back seems fine.

adamps’s picture

adamps commented

Great thanks everyone

  • longwave committed a4f5580c on 10.4.x 
    Issue #3342700 by quietone, pooja_sharma, AdamPS, jonathanshaw:...

  • longwave committed 41122f85 on 11.x 
    Issue #3342700 by quietone, pooja_sharma, AdamPS, jonathanshaw:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 41122f85dd to 11.x and a4f5580c86 to 10.4.x. Thanks!

longwave closed merge request !8937

quietone’s picture

quietone commented
Parent issue: » #2353867: [META] Expose Title and other base fields in Manage Display

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.