Problem/Motivation

  • Add a REST API and modify the SPA source code as well.

Issue fork cloud-3342633

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita’s picture

Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

Status: Needs review » Needs work

@ryo-yamashita

Thank you for adding the form. I posted my comments. Can you please check them?

Thanks

yas’s picture

yas’s picture

@ryo-yamashita

Can you also fix the following coding standard violations?

FILE: ...oud_service_providers/openstack/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 16 LINES
----------------------------------------------------------------------
 567 | ERROR | [x] Expected "string|null" but found "string|NULL" for
     |       |     function return type
 599 | ERROR | [x] Expected "string|null" but found "string|NULL" for
     |       |     function return type
 602 | ERROR | [ ] Private method name
     |       |     "ApiController::readSourceFromURL" is not in
     |       |     lowerCamel format
 619 | ERROR | [ ] The array declaration extends to column 96 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 625 | ERROR | [ ] The array declaration extends to column 95 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 628 | ERROR | [x] Use "elseif" in place of "else if"
 631 | ERROR | [ ] The array declaration extends to column 85 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 634 | ERROR | [x] Use "elseif" in place of "else if"
 637 | ERROR | [ ] The array declaration extends to column 96 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 648 | ERROR | [ ] The array declaration extends to column 91 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 657 | ERROR | [ ] The array declaration extends to column 98 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 660 | ERROR | [x] Use "elseif" in place of "else if"
 663 | ERROR | [ ] The array declaration extends to column 99 (the
     |       |     limit is 80). The array content should be split up
     |       |     over multiple lines
 668 | ERROR | [x] Array indentation error, expected 6 spaces but
     |       |     found 8
 669 | ERROR | [x] Array indentation error, expected 6 spaces but
     |       |     found 8
 670 | ERROR | [x] Array indentation error, expected 6 spaces but
     |       |     found 8
----------------------------------------------------------------------

Thanks

Ryo Yamashita’s picture

Status: Needs work » Needs review

@yas

I fixed coding standard violations. Thanks.

yas’s picture

Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I posted my comments. Can you please check them? Thanks!

Ryo Yamashita’s picture

Status: Needs work » Needs review

@yas

I checked and fixed this patch. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 2407106a on 5.x authored by Ryo Yamashita
    Issue #3342633 by Ryo Yamashita, yas: Add the function to create...
yas’s picture

Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

I found cloud_dashboard/cloud_dashboard/.node-version is missing in the 4.x branch. Can you fix it by adding the file and create a new patch for 4.x? Thanks!

Cloning into 'cloud'...

...

Writing objects: 100% (77109/77109), done.
Total 77109 (delta 57857), reused 77109 (delta 57857), pack-reused 0
 create mode 100644 modules/cloud_dashboard/cloud_dashboard/src/atoms/ErrorAlert.tsx
 create mode 100644 modules/cloud_dashboard/cloud_dashboard/src/pages/openstack/heat/OpenStackHeatCreatePage.tsx
error: modules/cloud_dashboard/cloud_dashboard/.node-version: No such file or directory
 .../cloud_dashboard/cloud_dashboard/.node-version  |    2 
 .../cloud_dashboard/src/atoms/ErrorAlert.tsx       |   16 +
 .../src/constant/templates/form/openstack/stack.ts |    6 
 .../cloud_dashboard/src/pages/EntityCreatePage.tsx |  388 ++++++++++++++------
 .../openstack/heat/OpenStackHeatCreatePage.tsx     |  337 +++++++++++++++++
 .../cloud_dashboard/src/service/convert.ts         |   89 +++--
 .../openstack/openstack.routing.yml                |   27 +
 .../openstack/src/Controller/ApiController.php     |  191 ++++++++++
 .../src/Service/OpenStackOperationsService.php     |    7 
 9 files changed, 903 insertions(+), 160 deletions(-)

error: modules/cloud_dashboard/cloud_dashboard/.node-version: No such file or directory
On branch 4.x
Your branch is up to date with 'origin/4.x'.

nothing to commit, working tree clean

Ryo Yamashita’s picture

Status: Needs work » Needs review

@yas

I created a new branch ("3342633-add-function-to-create-openstack-stack-patch") and pushed a new patch. Thanks.

yas’s picture

Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch for the branch 4.x. It looks good; but can you please push the patch for the branch at 3342633-add-function-to-create-openstack-stack to 3342633-add-function-to-create-openstack-stack-patch.

Ryo Yamashita’s picture

Status: Needs work » Needs review
yas’s picture

Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 276c840f on 4.x authored by Ryo Yamashita
    Issue #3342633 by Ryo Yamashita, yas: Add the function to create...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.