Closed (fixed)
Project:
Cloud
Version:
5.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
17 Feb 2023 at 08:13 UTC
Updated:
8 Mar 2023 at 03:44 UTC
Jump to comment: Most recent
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
Ryo Yamashita commented@yas
Please review it. Thanks.
Comment #4
yas@ryo-yamashita
Thank you for adding the form. I posted my comments. Can you please check them?
Thanks
Comment #5
yasComment #6
yas@ryo-yamashita
Can you also fix the following coding standard violations?
Thanks
Comment #7
Ryo Yamashita commented@yas
I fixed coding standard violations. Thanks.
Comment #8
yas@ryo-yamashita
Thank you for the update. I posted my comments. Can you please check them? Thanks!
Comment #9
Ryo Yamashita commented@yas
I checked and fixed this patch. Thanks.
Comment #10
yas@ryo-yamashita
Thank you for the update. It looks good to me now. I'll merge the patch to
4.xand5.x, and close this issue as Fixed.Comment #12
yas@ryo-yamashita
I found
cloud_dashboard/cloud_dashboard/.node-versionis missing in the4.xbranch. Can you fix it by adding the file and create a new patch for4.x? Thanks!Comment #14
Ryo Yamashita commented@yas
I created a new branch ("3342633-add-function-to-create-openstack-stack-patch") and pushed a new patch. Thanks.
Comment #15
yas@ryo-yamashita
Thank you for the patch for the branch
4.x. It looks good; but can you please push the patch for the branch at3342633-add-function-to-create-openstack-stackto3342633-add-function-to-create-openstack-stack-patch.Comment #16
Ryo Yamashita commentedComment #17
yas@ryo-yamashita
Thank you for the update. I'll merge the patch to
4.xand5.x, and close this issue as Fixed.Comment #19
yas