WCAG AAA Compliance issue.
F22: Failure of Success Criterion 3.2.5 due to opening windows that are not requested by the user
https://www.w3.org/TR/WCAG20-TECHS/F22.html
Running a AAA compliance tool detects the issue.
Displaying new windows without warning can be very confusing to non-sighted and mobile users. Some screen readers and mobile devices
give very little indication a new tab or window has opened. If you cannot avoid displaying a new window, insert a warning into the link text like
the following: "opens in a new window"
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3342632-11.patch | 4.4 KB | ameymudras |
| #8 | 3342632-8.patch | 4.51 KB | ameymudras |
| #4 | 3342632_4.patch | 4.46 KB | guptahemant |
| #3 | 3342632_3.patch | 4.39 KB | joshua1234511 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
joshua1234511Attached patch for 2.0.0 Release.
Comment #4
guptahemant commentedPatch in #2 introduces following issue:
The visual label must appear in the accessible name of links and controls,
Example Visual label: Facebook share(Opens in a new tab/window) not in Opens in a new tab/window
To fix this we need to make sure aria-label attribute contains the complete text which appear in link element.
Here ia patch which builds on top of #2 to fix this issue.
Comment #5
guptahemant commentedComment #6
paulrad commentedCan confirm that #4 addresses the reported issue. Moving to RTBC
Comment #7
paulrad commentedCan any maintainer review this issue?
Comment #8
ameymudras commentedThe patch #4 doesn't apply to the latest 2.x branch. I have re rolled the patch to fix the issue
Comment #9
ameymudras commentedComment #10
ameymudras commentedRe rolled the patch for the latest version
Comment #11
ameymudras commentedUpdated patch