Problem/Motivation

Add the advantage of Entity Print module support for the View Receipt. Already Drupal commerce 2.x supports the Entity Print module with commerce core.

As similar to Resend Email we can introduce View PDF option.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 Receipt-PDF.png120.02 KBarunkumark

Issue fork commerce_view_receipt-3342290

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arunkumark created an issue. See original summary.

arunkumark opened merge request !5

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
gregcube’s picture

gregcube commented

I like this idea, but it needs some work still.

$route_params = [
    'entity_type' => 'commerce_order',
    'entity_id' => 1,
    'export_type' => 'pdf'
];

We can't always assume entity id 1.

We should also add a requirement for entity_print or wrap something like:

if (\Drupal::moduleHandler()->moduleExists('entity_print')) {
  // Code Here
}

around it.

I think it would also be better implemented as a local action item.

gregcube’s picture

gregcube commented
Status: Needs review » Needs work
arunkumark’s picture

arunkumark
Location Coimbatore
commented

@gregcube
Adding the Local action item is better than having the Print link.

gregcube’s picture

gregcube commented
Status: Needs work » Needs review
gregcube’s picture

gregcube commented

Give the latest a try. Let me know how it works for you.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Issue tags: +RTBC
StatusFileSize
new Receipt-PDF.png120.02 KB

@gregcube

The updates look awesome. Attached screenshot of the testing. Good to move for RTBC, but keep any Needs Review to check by someone else.

PDF issue

++RTBC

RyanCMcConnell’s picture

RyanCMcConnell commented

Any idea what the holdup on this is? I'm planning on using the issue fork for my current project but I'd love if this was just the standard feature.

gregcube’s picture

gregcube commented

I'll get a new release rolled out right now.

gregcube’s picture

gregcube commented
Status: Needs review » Fixed
RyanCMcConnell’s picture

RyanCMcConnell commented

Awesome, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.