Cool module!

Problem/Motivation

The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/gutenberg_uswds/modules/gutenberg_uswds_card/gutenberg_uswds_card.info.yml
The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/gutenberg_uswds/modules/gutenberg_uswds_modal/gutenberg_uswds_modal.info.yml
The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/gutenberg_uswds/modules/gutenberg_uswds_summary_box/gutenberg_uswds_summary_box.info.yml

Steps to reproduce

Run 'drush en gutenberg_uswds' on a Drupal 9 site.

Proposed resolution

Remove the 'core: 8.x' line from these three files.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 with patch.png272.48 KBkenyoowen
#4 without patch.png683.01 KBkenyoowen
#3 3341947-3.patch1.55 KBmrinalini9

Comments

Deg created an issue. See original summary.

deg’s picture

deg commented
Issue summary: View changes
mrinalini9’s picture

mrinalini9 commented
Status: Active » Needs review
StatusFileSize
new 3341947-3.patch1.55 KB

Added patch for the above fixes, please review it.

Thanks & Regards,
Mrinalini

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new without patch.png683.01 KB
new with patch.png272.48 KB

Hi mrinalini9

I applied patch #3 against the Gutenberg USWDS
1.0.x-dev and with core version 9.5.3 and it is working properly as expected.

Please see the screenshot attached.

Thank You.

  • jidrone committed bef45196 on 1.0.x 
    Issue #3341947: Removed the 'core' key from modules
jidrone’s picture

jidrone commented
Status: Reviewed & tested by the community » Fixed

Pushed to the dev branch, thanks.

jidrone’s picture

jidrone commented
Status: Fixed » Closed (fixed)