Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cleantaxonomy/cleantaxonomy.drush.inc
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cleantaxonomy/src/Form/CleanTaxonomyReplaceForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  92 | WARNING | Unused variable $index.
 183 | ERROR   | Doc comment short description must start with a capital letter
 187 | WARNING | Unused variable $taxonomy_term_vid.
 220 | ERROR   | The array declaration extends to column 162 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cleantaxonomy/src/Commands/CleantaxonomyCommands.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 25 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 26 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 27 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

Time: 146ms; Memory: 10MB

Steps to reproduce

Run the following Command: phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /drupal/modules/contrib/cleantaxonomy

Proposed resolution

Fix all the PHP coding standard issues/warnings.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3341184-2.patch2.47 KBsahil.goyal

Issue fork cleantaxonomy-3341184

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sahil.goyal created an issue. See original summary.

sahil.goyal’s picture

sahil.goyal commented
Status: Needs work » Needs review
StatusFileSize
new 3341184-2.patch2.47 KB

Applying the patch to fix all the PHP coding standard issues and warnings.

hardikpandya’s picture

hardikpandya commented
Status: Needs review » Reviewed & tested by the community

I have checked the patch is applying and there are no more phpcs issues reported. Marking as RTBC!

hardikpandya opened merge request !6

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -

Fixed. Push to 2.0.x.
Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.