CommentFileSizeAuthor
#2 3340446-2.patch913 bytesgayatri chahar

Issue fork entity_reference_delete-3340446

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gayatri chahar created an issue. See original summary.

gayatri chahar’s picture

gayatri chahar commented
Assigned: gayatri chahar » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3340446-2.patch913 bytes

Patch created. Please review it

Jay Jangid made their first commit to this issue’s fork.

jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid
Issue summary: View changes

Jay Jangid opened merge request !1

jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
Issue summary: View changes

Thanks @gayatri chahar for creating patch.It's working fine for me.
Created MR after patch apply.
Please review this MR.

joachim’s picture

joachim commented
Version: 1.0.0-alpha1 » 1.0.x-dev
Category: Task » Bug report
Status: Needs review » Needs work

Thanks for the patch!

Let's call it a bug though - modules should provide a hook_help().

There's a few things that need fixing though:

  1. +++ b/entity_reference_delete.module
@@ -8,6 +8,23 @@
+

    Stray whitespace. 

  2. +++ b/entity_reference_delete.module
@@ -8,6 +8,23 @@
+{

    Opening bracket in wrong place. 

  3. +++ b/entity_reference_delete.module
@@ -8,6 +8,23 @@
+      $output .= '<p>' . t('TThe Entity Reference Delete module allows reference fields to enforce referential integrity by deleting related entities.') . '</p>';

    Typo: 'TThe'. 

  4. +++ b/entity_reference_delete.module
@@ -8,6 +8,23 @@
+    default:

    I don't think we need this.

jay jangid’s picture

jay jangid commented
Status: Needs work » Needs review

Fixed above issues.
Please check.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed, with a few further fixes.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.