Problem/Motivation

This was suggested by xjm while working on #3268809: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'.

Steps to reproduce

Proposed resolution

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3340147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.0.x-dev » 11.x-dev

ajinkya45 made their first commit to this issue’s fork.

ajinkya45 opened merge request !13203

ajinkya45’s picture

ajinkya45 commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
ajinkya45’s picture

ajinkya45 commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed here.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

One small thing on the MR

ajinkya45’s picture

ajinkya45 commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback from @mstrelan addressed.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Needs work

Needs a rebase. That will show failures related to usage of annotations instead of attributes in the test code, that will have to be fixed too.

ajinkya45’s picture

ajinkya45 commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The rebase was done. Tests are passing. I'm restoring the RTBC status per #11.

  • catch committed 3b9d87bc on 11.3.x 
    task: #3340147 Convert testSkipSecurityFilters() to a unit or kernel...

  • catch committed e26ec06c on 11.x 
    task: #3340147 Convert testSkipSecurityFilters() to a unit or kernel...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13203

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.