Problem/Motivation

Now that bootstrap5 3.0.3+ is using the Drupal core starter theme, the CSS files have incorrect paths to image icons via url().

Steps to reproduce

Load various pages of the site to experience missing images.

Proposed resolution

Correct the paths in the theme's CSS file to point to the icons located under the starter theme at /core/themes/starterkit_theme/images/icons

CommentFileSizeAuthor
#2 3340088.patch7.69 KBshefik

Comments

Shefik created an issue. See original summary.

shefik’s picture

shefik commented
StatusFileSize
new 3340088.patch7.69 KB

Patch file is attached to correct the issue.

natts’s picture

natts
He/they
Primary language English
Location London
commented
Status: Active » Needs review
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 3.0.3 » 3.0.x-dev
Status: Needs review » Postponed (maintainer needs more info)

This pull request doesn't make sense.

Modifications suggest that

  • this is for different theme
  • patch was generated from application perspective (not theme perspective) so it will never apply

i.e. themes/contrib/bootstrap/css/components/dialog.css

natts’s picture

natts
He/they
Primary language English
Location London
commented

Oddly, on an installation where I don't have the bootstrap theme installed, this patch still worked on my bootstrap5 theme, updating the 25 references to the 24 starterkit_theme image icons across 6 bootstrap5 CSS files accordingly. I applied it using cweagans/composer-patches.

shefik’s picture

shefik commented

This patch is no longer needed, since the issue has been resolved, along with the release of version bootstrap5 3.0.4.

https://drupal.org/project/bootstrap5/issues/3342492

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)