Problem/Motivation

  • Breadcrumbs should be displayed correctly in every SPA view.

Issue fork cloud-3339470

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs review » Needs work

Ryo Yamashita opened merge request !1561

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas @hosomi

Please review it. Thanks.

hosomitm’s picture

hosomitm commented

@ryo-yamashita

This code looks good to me.

However, as a detailed point, there seems to be a typo in the comment line.
Breadcrumbs.tsx
line:41 "Crate"

Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix it so that the breadcrumbs are displayed correctly in the SPA » Fix to display breadcrumbs correctly in the SPA
Issue summary: View changes
Status: Needs review » Needs work

@hosomi

Thank you for your review.

@ryo-yamashita

I posted my comment to GitLab code review. Can you please fix it?

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas @hosomi

I fixed the typo. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the fix. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 0a504d9f on 5.x authored by Ryo Yamashita 
    Issue #3339470 by Ryo Yamashita, yas, hosomitm: Fix to display...

  • yas committed 0562e3c9 on 4.x authored by Ryo Yamashita 
    Issue #3339470 by Ryo Yamashita, yas, hosomitm: Fix to display...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.