Problem/Motivation
We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.
Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2-after.png | 70.29 KB | ravi kant |
| #9 | 2-patch-applying.png | 121.32 KB | ravi kant |
| #9 | 2-before.png | 64.95 KB | ravi kant |
| #8 | 3339456 - after MR.png | 458.1 KB | kenyoowen |
| #8 | 3339456 - before MR.png | 453.98 KB | kenyoowen |
Issue fork webform_mass_email-3339456
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
Sonal Gyanani commentedCreated MR for the issue.
Please review.
Thanks
Comment #4
kenyoowen commentedHi Sonal Gyanani
I reviewed and apply your MR and the README.txt isn't replaced with README.md. And it also missing some information, please update it according to README.md template
Please see the screenshots attached.
Thank you.
Comment #5
nitin_lamaComment #6
nitin_lamaAddressed #4. Please review.
Comment #7
nitin_lamaComment #8
kenyoowen commentedHi nitin_lama
I reviewed and applied your MR it follows the README.md template, but it didn't replaced README.txt with README.md. Please see the screenshots attached.
Thank you.
Comment #9
ravi kant commented@kenyoOwen
It is working for me.
Comment #10
nupur badola commentedReviewed MR!3, the file is updated as per the readme.md file template.
Hence marking it to RTBC.
Comment #13
kybermanThank you very much! This is now merged to dev, and the new release is on the way.