Problem/Motivation

Getting following error.

FILE: /var/www/html/modules/contrib/webform_mass_email/src/Plugin/QueueWorker/WebformMassEmailQueue.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

Time: 1.5 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/webform_mass_email/

Proposed resolution

Above error need to be fixed.

CommentFileSizeAuthor
#2 3339444-2.patch983 bytessamitk

Issue fork webform_mass_email-3339444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3339444-2.patch983 bytes

Above error are fixed.

Charchil Khandelwal made their first commit to this issue’s fork.

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: Unassigned » charchil khandelwal

I will review this.

Charchil Khandelwal opened merge request !1

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: charchil khandelwal » Unassigned

Patch #2 tested and applied successfully, all the errors and warnings are fixed.
Created MR for easy preview and commenting.
RTBC +1.

Thanks.

cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -, -

Hi @Charchil Khandelwal,

I applied MR!1, it was applied smoothly and fixed all phpcs issues

➜  webform_mass_email git:(8bb411d) curl https://git.drupalcode.org/project/webform_mass_email/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1049    0  1049    0     0   3140      0 --:--:-- --:--:-- --:--:--  3140
patching file src/Plugin/QueueWorker/WebformMassEmailQueue.php
➜  webform_mass_email git:(8bb411d) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_mass_email
➜  contrib

Thank you.

kyberman’s picture

kyberman
Location Czech Rep. 🇨🇿
commented
Status: Reviewed & tested by the community » Fixed

Thank you very much! This is now merged to dev, and the new release is on the way.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.