CommentFileSizeAuthor
#8 remove-unused-imports-3338864-8.patch1.37 KBannmarysruthy
#2 3338864.patch942 bytesgayatri chahar

Issue fork simple_password_policy-3338864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gayatri chahar created an issue. See original summary.

gayatri chahar’s picture

gayatri chahar commented
Assigned: gayatri chahar » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3338864.patch942 bytes

Patch created. Please review it

tra.duong’s picture

tra.duong commented
Issue summary: View changes
Status: Needs review » Needs work

@gayatri chahar Your patch works.

However, there is something left over

In /src/PasswordPolicy.php:

-use Drupal\user\Entity\User;

In /src/PasswordPolicyInterface.php:

- use Drupal\simple_password_policy\Event\PasswordPolicyExpireEvent;
- use Drupal\simple_password_policy\Event\PasswordPolicyWarningEvent;

Regards.

kriboogh’s picture

kriboogh commented

Also, please use the fork and merge request system to provide patches.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

sourabhjain opened merge request !5

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
Status: Needs work » Needs review

I have updated the changes mentioned in #3 and created the PR. Please review.

annmarysruthy’s picture

annmarysruthy commented
StatusFileSize
new remove-unused-imports-3338864-8.patch1.37 KB

Patch in #6 failed to apply and I have created a new patch to resolve the issue. Please review

  • kriboogh committed cbe5753b on 1.0.x authored by sourabhjain 
    Issue #3338864 by sourabhjain, gayatri chahar, kriboogh: Remove unused...
kriboogh’s picture

kriboogh commented
Status: Needs review » Needs work

Hiding files since we only work with merge requests.
#7 got merged. thanks

kriboogh’s picture

kriboogh commented
Status: Needs work » Fixed
kriboogh’s picture

kriboogh commented
Status: Fixed » Closed (fixed)