Problem/Motivation

Address standards in these js files

js/module_filter.modules.js
js/module_filter.modules_bare.js
js/module_filter.modules_tabs.js

Steps to reproduce

NA

Proposed resolution

Address issues or document why we can't

Remaining tasks

Implement
Test each file
Review

User interface changes

NA

API changes

NA

Data model changes

NA

Issue fork module_filter-3338339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !27

smustgrave’s picture

smustgrave commented

Surprised a number of errors wonder if that's the right way. Was following my phpstorm.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

You have fixed evertything in one hit! Nice work. I don't have phpstorm or eslint, so was doing it bit by bit.

Remember we do not have javascript tests for everything you are changing here, so it will need manual testing.

smustgrave’s picture

smustgrave commented

Was able to fix some the estlin suppressions. Some of them are just not worth it. Like turning this into it's own function variable

function () {
    if (this.activeTab) {
      return this.activeTab;
    }
  };

For about 20 instances.

smustgrave’s picture

smustgrave commented
Status: Needs review » Closed (outdated)

Added an estlint style file to the repo in the gitlab and got a whole other set of errors (but smaller) so closing this out.

smustgrave’s picture

smustgrave commented
Status: Closed (outdated) » Needs work
smustgrave’s picture

smustgrave commented

Actually just going to open a new MR.

smustgrave opened merge request !32

smustgrave closed merge request !27

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Finally got this to a good state. Merged this for the other tickets/MRs

smustgrave’s picture

smustgrave commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.