Drupal Coding Standards Issues | phpcs [#3337898]

Problem/Motivation

Getting Following errors/warnings

$ phpcs --standard=Drupal views_filters_combine_field

FILE: ...esktop\task\views_filters_combine_field\js\views_filters_combine_fields.js
--------------------------------------------------------------------------------
FOUND 71 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------
   1 | ERROR | [x] End of line character is invalid; expected "\n" but found
     |       |     "\r\n"
  21 | ERROR | [x] Expected 1 space before "="; 0 found
  21 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "<"; 0 found
  33 | ERROR | [x] Expected 1 space after "<"; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "-"; 0 found
  33 | ERROR | [x] Expected 1 space after "-"; 0 found
  33 | ERROR | [x] Expected 1 space before "-"; 0 found
  33 | ERROR | [x] Expected 1 space after "-"; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before ">"; 0 found
  33 | ERROR | [x] Expected 1 space after "<"; 0 found
  33 | ERROR | [x] Expected 1 space before "/"; 0 found
  33 | ERROR | [x] Expected 1 space after "/"; 0 found
  33 | ERROR | [x] Expected 1 space before ">"; 0 found
  33 | ERROR | [x] Expected 1 space after ">"; 0 found
  55 | ERROR | [x] Expected 1 space before "="; 0 found
  55 | ERROR | [x] Expected 1 space after "="; 0 found
  59 | ERROR | [x] Expected 1 space before "="; 0 found
  59 | ERROR | [x] Expected 1 space after "="; 0 found
  77 | ERROR | [x] Expected 1 space before "="; 0 found
  77 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "<"; 0 found
  82 | ERROR | [x] Expected 1 space after "<"; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "-"; 0 found
  82 | ERROR | [x] Expected 1 space after "-"; 0 found
  82 | ERROR | [x] Expected 1 space before "-"; 0 found
  82 | ERROR | [x] Expected 1 space after "-"; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before ">"; 0 found
  82 | ERROR | [x] Expected 1 space after ">"; 0 found
  99 | ERROR | [x] Expected 1 space before "="; 0 found
  99 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "<"; 0 found
 104 | ERROR | [x] Expected 1 space after "<"; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "-"; 0 found
 104 | ERROR | [x] Expected 1 space after "-"; 0 found
 104 | ERROR | [x] Expected 1 space before "-"; 0 found
 104 | ERROR | [x] Expected 1 space after "-"; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before ">"; 0 found
 104 | ERROR | [x] Expected 1 space after ">"; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...\task\views_filters_combine_field\src\Plugin\views\filter\CombineField.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found
   |       |     "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 491ms; Memory: 10MB

Proposed resolution

Fix the errors and warnings.

Comment	File	Size	Author
#5	3337898-5.patch	3.22 KB	mukesh88

Issue fork views_filters_combine_field-3337898

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3337898-drupal-coding-standards changes, plain diff MR !3
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

31 January 2023 at 12:06

Jay Jangid created an issue. See original summary.

Comment #2

31 January 2023 at 12:07

Jay Jangid opened merge request !3

Comment #3

jay jangid commented 31 January 2023 at 12:07

Assigned:	jay jangid	» Unassigned
Status:	Active	» Needs review

Created MR ,please review.

Thank you.

Comment #4

jitesh_1

English

Jaipur

commented 8 February 2023 at 14:34

Status:

Needs review

» Needs work

Hello @Jay Jangid,
After applying mr the module is not working.

Comment #5

mukesh88 commented 24 March 2023 at 08:17

Status	File	Size
new	3337898-5.patch	3.22 KB

PHPCs issue fixes

Comment #6

mukesh88 commented 24 March 2023 at 08:17

Status:

Needs work

» Needs review

Comment #7

vandna b commented 1 August 2023 at 07:36

#5 patch is failed to apply.

Comment #8

keshavv commented 1 August 2023 at 07:37

Status:

Needs review

» Needs work

@mukesh88 #5 patch Failed to apply. Due to some recent code changes.

I reviewed the MR as well and confirmed that there are some unnecessary changes. Can you please update the MR instead of creating a patch or can you please reroll the patch with the latest code?

Thank you.

Comment #9

7 August 2023 at 13:09

nitin_lama made their first commit to this issue’s fork.

Comment #10

zkhan.aamir commented 20 October 2023 at 06:23

Status:

Needs work

» Needs review

Issue summary updated

Comment #11

chetan 11 commented 20 October 2023 at 06:25

Assigned:

Unassigned

» chetan 11

Comment #12

chetan 11 commented 20 October 2023 at 06:41

Assigned:	chetan 11	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Hi,
The given MR #9 is resolving all the phpcs error on the above module.
Moving this to +RTBC.
Thanks

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Proposed resolution

Issue fork views_filters_combine_field-3337898

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

News items

Our community

Documentation

Drupal code base

Governance of community