Problem/Motivation

When you enable the module, the method hook_help is not implemented.

Steps to reproduce

Download and activate the module and visit it's help page.

Proposed resolution

Implement the hook_help and describe the functionality of the module and it's usage.

Remaining tasks

Implement hook_help.

CommentFileSizeAuthor
#12 Help.png51.47 KBBushra Shaikh
#8 Screenshot from 2024-03-26 00-03-46.png11.28 KBshivamsen_12579
#8 Screenshot from 2024-03-26 00-03-46.png11.28 KBshivamsen_12579
#5 after_patch.png13.91 KBtanuja bohra
#5 before_patch.png13.26 KBtanuja bohra
#4 Field_formatters.png72.86 KBnupur badola

Issue fork field_formatter-3337822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jay Jangid created an issue. See original summary.

Jay Jangid opened merge request !9

jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
Status: Active » Needs review

Created MR , please review.

Thank you.

nupur badola’s picture

nupur badola commented
StatusFileSize
new Field_formatters.png72.86 KB

Module is not present. refer the below snapshot.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png13.26 KB
new after_patch.png13.91 KB

Verified the MR9 on 9.5.8, help() is added. Added screenshots for reference, RTBC++.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

I take comment #4 is saying the MR does not work as expected.

shivamsen_12579 made their first commit to this issue’s fork.

shivamsen_12579’s picture

shivamsen_12579 commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2024-03-26 00-03-46.png11.28 KB
new Screenshot from 2024-03-26 00-03-46.png11.28 KB

implemented hook_help and removed phpcs issues. please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

The purpose of this issue is implementing hook_help(), not fixing coding issue in other files.

apaderno opened merge request !13

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Help.png51.47 KB

I have verified and applied MR !3 #11 on the Drupal 9.5.11 version.
Patch applied successfully, and help() is added cleanly. Added screenshots for reference.

Can be moved to RTBC+1.

Anybody changed the visibility of the branch 3337822-implement-hookhelp to hidden.

Anybody closed merge request !9

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Merged, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.