Fix the issues reported by phpcs [#3337516]

Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/workbench_reviewer/tests/src/Functional/WorkbenchReviewerFormTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/workbench_reviewer/README.md
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 282 characters
7 | WARNING | Line exceeds 80 characters; contains 142 characters
17 | WARNING | Line exceeds 80 characters; contains 104 characters
22 | WARNING | Line exceeds 80 characters; contains 165 characters
24 | WARNING | Line exceeds 80 characters; contains 143 characters
26 | WARNING | Line exceeds 80 characters; contains 194 characters
28 | WARNING | Line exceeds 80 characters; contains 247 characters
32 | WARNING | Line exceeds 80 characters; contains 159 characters
-----------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/workbench_reviewer/workbench_reviewer.module
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
96 | WARNING | [ ] Unused variable $node.
139 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run the following command : phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /10.1.x/drupal/modules/contrib/workbench_reviewer

Proposed resolution

Fix the above errors.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#10	comment-remove-3337516-3.patch	421 bytes	himanshu_jhaloya
#7	after patch.png	68.1 KB	paraderojether
#7	before patch.png	261.57 KB	paraderojether
#2	3337516-2.patch	4.85 KB	sahil.goyal

Issue fork workbench_reviewer-3337516

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3.0.x changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally
3337516-drupal-coding-standards compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

30 January 2023 at 10:06

sahil.goyal created an issue. See original summary.

Comment #2

sahil.goyal commented 30 January 2023 at 10:08

Status	File	Size
new	3337516-2.patch	4.85 KB

Fixing the phpcs issues/erros

Comment #3

30 January 2023 at 11:24

Charchil Khandelwal made their first commit to this issue’s fork.

Comment #4

charchil khandelwal commented 30 January 2023 at 11:25

Assigned:

Unassigned

» charchil khandelwal

I will review this.

Comment #5

30 January 2023 at 11:35

Charchil Khandelwal opened merge request !1

Comment #6

charchil khandelwal commented 30 January 2023 at 11:36

Assigned:	charchil khandelwal	» Unassigned
Status:	Needs work	» Needs review

All warnings and errors are fixed now.
Created MR for same.
Please review.

Comment #7

paraderojether commented 2 May 2023 at 03:17

Status:	Needs review	» Reviewed & tested by the community
Issue tags:	-

Status	File	Size
new	before patch.png	261.57 KB
new	after patch.png	68.1 KB

Hi Charchil Khandelwal

I reviewed MR!1, and confirmed it fixes the issue reported by the phpcs. Drupal core version 9.5.8, Workbench Reviewer 3.0.0-beta1.

I added screenshots for reference.
Thank You.

Comment #8

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 2 May 2023 at 09:04

Title:	Drupal Coding Standards Issues \| phpcs	» Fix the issues reported by phpcs
Version:	3.0.0-beta1	» 3.0.x-dev
Category:	Bug report	» Task
Priority:	Normal	» Minor
Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Coding standards

 function workbench_reviewer_entity_presave(EntityInterface $entity) {
   if ($entity->getEntityTypeId() === 'node') {
-    $node = $entity;
+    // $node = $entity;
   }
 }

If a line must be removed, it is not commented out.