Problem/Motivation

When JS Aggregation is enabled js-cookie library doesn't load - appears to almost be a duplicate of #3047805: CSS and JS aggregation prevents AblePlayer from loading

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3335910-2-js-cookie0library-doesnt-load-with-aggregation.patch539 bytesjrglasgow

Issue fork ableplayer-3335910

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrglasgow created an issue. See original summary.

jrglasgow’s picture

jrglasgow commented
StatusFileSize
new 3335910-2-js-cookie0library-doesnt-load-with-aggregation.patch539 bytes

here is a patch that fixes it by telling Drupal not to try to preprocess/aggregate this library

jrglasgow’s picture

jrglasgow commented
Status: Active » Needs review

jrglasgow opened merge request !21

themusician’s picture

themusician commented

Hi @jrglasgow. Thanks for reporting this and supplying a patch file.

I can't reproduce the issue on my end. What version of Drupal are you using? Before merging the patch I want to be able to reproduce the issue. I agree it sounds just like the last time this occurred within the project.

Thank you.

jrglasgow’s picture

jrglasgow commented

@theMusician,
I have run into this problem with Drupal 9.5.3

themusician’s picture

themusician commented

Thank you. It seems like Drupal is not supposed to aggregate external libraries, https://www.drupal.org/docs/develop/creating-modules/adding-assets-css-j..., but it couldn't hurt to make it explicit as you do with the patch. Especially since that makes it work.

themusician’s picture

themusician commented
themusician’s picture

themusician commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.