Drupal Coding Standards Issues | phpcs [#3335596]

Problem/Motivation

Getting following warnings.

FILE: /var/www/html/modules/contrib/rsg/src/RandomGenerator.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
182 | WARNING | Exceptions should not be translated
182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

Time: 2.04 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/rsg/

Proposed resolution

Above warnings need to be fixed.

Comment	File	Size	Author
#8	rsg-after-patch.png	23.68 KB	rishu_kumar
#2	3335596-2.patch	511 bytes	samitk

Issue fork rsg-3335596

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

main changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

23 January 2023 at 05:08

samit.310@gmail.com created an issue. See original summary.

Comment #2

samitk commented 23 January 2023 at 05:09

Assigned:	samitk	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3335596-2.patch	511 bytes

Above warnings are fixed.

Comment #3

charchil khandelwal commented 23 January 2023 at 05:15

Assigned:

Unassigned

» charchil khandelwal

Comment #4

charchil khandelwal commented 23 January 2023 at 05:55

Status:

Needs review

» Needs work

The patch #2 has been reviewed and applied cleanly, but a few phpcs still remain.

FILE: C:\Users\Admin\Downloads\rsg\rsg.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added
| | by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be
| | added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added
| | by drupal.org packaging automatically
----------------------------------------------------------------------

Time: 539ms; Memory: 10MB

Comment #5

charchil khandelwal commented 23 January 2023 at 06:08

Assigned:

charchil khandelwal

» Unassigned

Comment #6

samitk commented 23 January 2023 at 06:44

Status:

Needs work

» Needs review

Hi @Charchil Khandelwal,

I checked rsg.info.yml file, The project, datestamp, version keys are not there. Please check below

name: Random String Generator
type: module
description: Module for generating the random string based on length and type.
core_version_requirement: ^8 || ^9 || ^10
package: String

Looks like you download that module with composer or manually. Please download it with git by following command, than try that patch.

git clone https://git.drupalcode.org/project/rsg.git