Closed (fixed)
Project:
Choices.js - Better Vanilla JS Select Widget
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Jan 2023 at 10:24 UTC
Updated:
13 Feb 2023 at 15:29 UTC
Jump to comment: Most recent
Comments
Comment #4
grevil commentedFixed using PHPStan and the "upgrade_status" module.
Tested installing the module on Drupal 10 after the changes.
Comment #5
grevil commentedInteresting, upgrade_status forgot to mention the test module! Fixed, please review.
Comment #6
anybodyThanks @Grevil!
I think all
.info.ymlfiles should have an equalcore_version_requirement.If that's not possible, we should perhaps increase the values for all?
Comment #7
grevil commentedI think it is fine in this case, as the only info file that differentiates, is for the test module.
Comment #8
anybodyLet's remove the core_version_requirement as of #3096609: Allow contrib test modules to not need a core or core_version_requirement key
Comment #10
anybodyMerged!