Problem/Motivation

dev dependency media_entity_instagram:^2.1 is not d10 compatible

Steps to reproduce

Run CI tests with Drupal 10
Example from open issues:
https://www.drupal.org/pift-ci-job/2570108

Proposed resolution

Use media_entity_instagram^3 or check if it's really needed

Issue fork custom_elements-3335258

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mostepaniukvm created an issue. See original summary.

mostepaniukvm opened merge request !20

mostepaniukvm’s picture

mostepaniukvm
he/him
commented

Looks like it needs a little more work to make tests run on Drupal 10.
Will change the configuration to trigger Drupal 9 tests on commit before we will solve this

fago’s picture

fago
Primary language German
Location Vienna
commented
Category: Support request » Bug report
fago’s picture

fago
Primary language German
Location Vienna
commented

hm, I think this is only used in the thunder sub-module. This is optionally, so it seems silly to block people tests by it.

Could we just allow installing 2.x and 3.x in composer deps?

mostepaniukvm’s picture

mostepaniukvm
he/him
commented

I checked and not sure if media_entity_instagram is needed at all. Tried to delete it but got other failures that need to be corrected in tests. It shouldn't be a big one. Meanwhile, I changed the configuration to trigger tests with 9.5

mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Status: Active » Needs review

Did a few more corrections and now it works. Needs review

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

all great!

  • mostepaniukvm committed 44bc0e82 on 8.x-2.x 
    Issue #3335258 by mostepaniukvm, fago: CI tests are failing on Drupal 10

  • mostepaniukvm committed 44bc0e82 on 3.x 
    Issue #3335258 by mostepaniukvm, fago: CI tests are failing on Drupal 10
mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Status: Reviewed & tested by the community » Fixed

Merged to 2.x and 3.x branches and configured automated tests running

mostepaniukvm’s picture

mostepaniukvm
he/him
commented

for both 2.x and 3.x branches configured next tests:
- PHP 8.2 & MySQL 8, D10 - on commit
- PHP 8.1 & MariaDB 10.3.22, D9.5 - weekly to see if no regression on Drupal 9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.