Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
user interface text
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Nov 2008 at 18:50 UTC
Updated:
2 Jan 2014 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
keith.smith commentedWe'd have to do this for 7.x and forward, as 6.x strings are frozen for translation (and it's arguably not worth breaking translations to eliminate an extra period).
Comment #2
beekerstudios commentedAgreed, but I thought I would do my part and notify.
Comment #3
keith.smith commentedStrictly speaking, those ending periods are unnecessary in these few cases, due to the order of the keywords.
Who knew we talked about bungee jumping so often in core.
And, further, why do we refer to keywords as "character sequences"? I think that's somewhat stilted, but perhaps there's some sort of transliteration or translation reason for doing so.
Comment #4
joachim commentedSimilarly to http://drupal.org/node/242048, I think 'bungee jumping' and 'funny' should be replaced with something a bit more suitable for the average site.
Comment #5
damien tournoud commentedCould we change "character sequences" by something less geeky? "Sentence" for example?
Comment #6
catchphrases, maybe? Character sequences is terrible.
Comment #7
keith.smith commentedMaybe "phrases" will work. Thanks catch.
Comment #9
catchbroken HEAD.
Comment #11
morbus iffAs the original writer of that sentence with the extra ending period, I gasp.
Definitely should not have the additional period - the one in Inc. is good enough.
Comment #12
catchComment #13
morbus iff[catch: to clarify I looked at the patch but did not ACTUALLY patch the source and test to
ensure things continued to work; therefore, I did NOT change the state to "tested by"]
Comment #14
catchMorbus, yes I set this to RTBC because there was agreement, with this string change I think it's fine to rely on the test bot to ensure everything works.
Comment #15
joachim commentedCan we deal with bungee jumping or is that for another issue and another patch?
Comment #16
morbus iffBungee jumping is opinion-based. The terminating period is a fact.
Let's get facts straightened out and then care about stupid shit ;)
Comment #17
webchickCool! Committed to HEAD. I agree; let's get rid of "bungee jumping" next.
I don't think we can back-port this to D6 because it would break translations.