According to EntityFormInterface this method should return integer value indicating the result of the operation.

Unlike #3264370: Remove return value from EntityFormInterface::save this issue is a bit more complicated because in some conditions \Drupal\comment\CommentForm::save may not perform any operations. So that it's not clear what it should return.
Basically we have two options here.
1. Introduce new "SAVED" constant. Something like SAVED_SKIPPED
2. Refactor CommentForm to not check permissions in submit handler.

Issue fork drupal-3333688

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

chi’s picture

chi commented
Issue summary: View changes

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ankitv18 made their first commit to this issue’s fork.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.