Problem/Motivation

When canExpose or anything disables the expose checkbox in the Views UI, Claro will silently fail to do anything due to

Warning: Undefined array key "expose_button" in core/themes/claro/claro.theme on line 1556

Steps to reproduce

  1. Enable Claro as your admin theme
  2. Find a filter with canExpose set to false,
  3. Try to add/edit that filter

Proposed resolution

Check existence before acting on that key

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3333664

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Claro » Claro: Undefined array key "expose_button"

joelpittet opened merge request !3246

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Seems simple enough for me to fix without adding test coverage.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed to 10.1.x and cherry-picked to 10.0.x and 9.5.x as a low-risk bug fix. Thanks!

  • longwave committed 4c1bcc3f on 10.0.x 
    Issue #3333664 by joelpittet, lauriii: Claro: Undefined array key "...

  • longwave committed 24bfe952 on 10.1.x 
    Issue #3333664 by joelpittet, lauriii: Claro: Undefined array key "...

  • longwave committed 03d95331 on 9.5.x 
    Issue #3333664 by joelpittet, lauriii: Claro: Undefined array key "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.