Problem/Motivation

When you enable the module, the method hook_help is not implemented.

Steps to reproduce

Download and activate the module and visit its help page.

Proposed resolution

Implement the hook_help and describe the functionality of the module and it's usage.

Remaining tasks

Implement hook_help.

CommentFileSizeAuthor
#14 after patch.png73.93 KBparaderojether
#12 3333588-8.patch1.29 KBhimanshu_jhaloya
#7 3333588-7.patch1.29 KBgayatri chahar
#6 3333588-6.patch1.29 KBgayatri chahar
#4 3333588-4.patch2.46 KBdharmeshbarot
#3 3333588-3.patch1.28 KBgayatri chahar
#2 Add_hook_help-3333588-2.patch1.28 KBjitesh_1

Issue fork private_message_invite-3333588

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jitesh_1 created an issue. See original summary.

jitesh_1’s picture

jitesh_1
Primary language English
Location Jaipur
commented
StatusFileSize
new Add_hook_help-3333588-2.patch1.28 KB

The next patch solves the task.

gayatri chahar’s picture

gayatri chahar commented
Status: Active » Needs review
StatusFileSize
new 3333588-3.patch1.28 KB

I submitted patch with some changes
Please review it
Thanks

dharmeshbarot’s picture

dharmeshbarot commented
StatusFileSize
new 3333588-4.patch2.46 KB

added content in hook_help()! needs review

paraderojether’s picture

paraderojether commented

@ gayatri chahar

I applied patch #3 against Private Message Invites 1.0.4 with Drupal core version 9.4.7 and I am getting this error:

"Fatal error: Cannot redeclare private_message_help() (previously declared in /var/www/docroot/modules/private_message/private_message.module:481) in /var/www/docroot/modules/private_message_invite/private_message_invite.module on line 22"

The error can be fixed by renaming the private_message_help into 'private_message_invite_help'.

Please check.

Thank You.

gayatri chahar’s picture

gayatri chahar commented
StatusFileSize
new 3333588-6.patch1.29 KB

Addressed #5 comment and made changes in patch
Thanks @paraderojether

gayatri chahar’s picture

gayatri chahar commented
StatusFileSize
new 3333588-7.patch1.29 KB

Please review this one.
Thanks

paraderojether’s picture

paraderojether commented

Hi @gayatri chahar

I reviewed patch #7 and there's another concern about this patch is getting this Warning: file_get_contents(/var/www/docroot/modules/private_message_invite/README.md): Failed to open stream: No such file or directory in private_message_invite_help() (line 25 of /var/www/docroot/modules/private_message_invite/private_message_invite.module). I just realized that README.txt is not yet replaced with README.md, and this warning can be fixed by replacing the README.md with => README.txt in this line $text = file_get_contents(__DIR__ . '/README.md');.

Could you update the patch?
Thanks!

paraderojether’s picture

paraderojether commented
Status: Needs review » Needs work

himanshu_jhaloya made their first commit to this issue’s fork.

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: Unassigned » himanshu_jhaloya
himanshu_jhaloya’s picture

himanshu_jhaloya commented
Status: Needs work » Needs review
StatusFileSize
new 3333588-8.patch1.29 KB

Reroll the patch #7 please review

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after patch.png73.93 KB

Hi @ himanshu_jhaloya

I applied patch #12 and this now works fine for me.

Thank You.

raveen_thakur51 made their first commit to this issue’s fork.

raveen_thakur51 opened merge request !5

manpreet_singh’s picture

manpreet_singh commented
manpreet_singh’s picture

manpreet_singh commented
Status: Reviewed & tested by the community » Fixed
manpreet_singh’s picture

manpreet_singh commented
Status: Fixed » Closed (fixed)