In default.settings.php most of the config settings have a one line hint where it should go. This is useful when automating settings.php file generation. Trusted host configuration (trusted_host_patterns) does not have this hint.
Look at default.settings.php.
Add missing hint.
Do it.
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot Before.png | 89.21 KB | rinku jacob 13 |
| #6 | Screenshot After.png | 97.45 KB | rinku jacob 13 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mustanggb commentedCreated merge request: https://git.drupalcode.org/project/drupal/-/merge_requests/3239
Would appreciate if this is accepted could it be backported to D9.
Comment #4
mustanggb commentedComment #5
mustanggb commentedReported test failure here: #3333292: Automated tests against D10.1 are broken.
Comment #6
rinku jacob 13 commentedReviewed Merge request !3239 on drupal version 10.1.x-dev. After the merge request we can see trusted_host_patterns on line number 708 of default.settings.php file. Need RTBC+1
Comment #7
smustgrave commentedTagging for release manager thought.
There is already documentation for trusted_host_patterns. The example being added could lead to bad practice of users not setting a trusted host I would be afraid of
Comment #8
xjmWe should manually test whether the status report still displays the expected error if it's set to an empty array instead of NULL. If the error is still displayed, I think this is OK.
@Rinku Jacob 13, thank you for looking into this issue.
Posting screenshots of your codebase or command-line interface does not advance the issue, since the automated testing infrastructure tells us whether the change set still applies correctly.
So, I have not granted issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!
See the issue credit guidelines for more information.
Comment #9
smustgrave commentedSo did add
$settings['trusted_host_patterns'] = [];
to my settings and cleared cached and I didn't get an error.
Comment #10
longwaveCommitted and pushed 945c48ff03 to 10.1.x. Thanks!