Problem/Motivation

hook_help function missing in .module file

CommentFileSizeAuthor
#9 live_editor_help_page.png87.31 KBparaderojether
#9 after patch.png48.23 KBparaderojether
#9 before patch.png43.95 KBparaderojether
#4 Screenshot from 2023-01-19 14-33-55.png14.88 KBsharayurajput
#4 Screenshot from 2023-01-19 14-33-59.png51.83 KBsharayurajput

Issue fork live_editor-3333279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !1

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Hi i create MR for hook_help function in .module file.
Please review.
Thanks.

sharayurajput’s picture

sharayurajput commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2023-01-19 14-33-59.png51.83 KB
new Screenshot from 2023-01-19 14-33-55.png14.88 KB

MR is reviewed its working good as per requirement, attached screenshot
LGTM so moving to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work 
+      $output = '';
+      $output .= '<h3>' . t('About') . '</h3>';
+      $output .= '<p>' . t('This module is in a development version, potentially dangerous if used in a production environment.') . '</p>';
+      return $output;

That does not describe what the module purpose is.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: hook_help function missing in .module file » hook_help() is not implemented
admin@azhark.com’s picture

admin@azhark.com commented
Title: hook_help() is not implemented » Implement hook_help()
admin@azhark.com’s picture

admin@azhark.com commented
Status: Needs work » Needs review
paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before patch.png43.95 KB
new after patch.png48.23 KB
new live_editor_help_page.png87.31 KB

Hi @admin@azhark.com

I reviewed MR!1, I applied it on my local, it looks good and it describes the purpose of the module. Drupal core 9.5.7, Live Editor 1.0.x-dev.

I added screenshot for reference.
Thank You.

carlosgm91 made their first commit to this issue’s fork.

carlosgm91’s picture

carlosgm91 commented

Hello, sorry for the delay, this module started as a test, and we have given it little maintenance, thank you very much for the improvements.

carlosgm91’s picture

carlosgm91 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.