This module is still using old README.md template format in README.md file.

Follow the pattern in the README.md template.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Charchil Khandelwal created an issue. See original summary.

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani’s picture

Status: Active » Needs review

Created MR for the issue according to Readme.md template format.
Please review.
Thanks

kavitha89’s picture

Status: Needs review » Needs work
StatusFileSize
new28.6 KB

When trying to apply the patch, the following can be observed:

7.patch:18: trailing whitespace.
# Calendar Link
7.patch:63: trailing whitespace.
library as its foundation. Use composer to install the module
7.patch:73: trailing whitespace.
- Install with composer to ensure dependencies are also installed:
7.patch:79: trailing whitespace.
- Install as you would normally install a contributed Drupal module. For
7.patch:112: trailing whitespace.
Returns an array of links for all available calendar types. Each
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.

thakurnishant_06’s picture

Status: Needs work » Needs review
StatusFileSize
new5.65 KB

Hello Everyone !!
Created a #6 patch for calender link 3.0.x-dev. The patch successfully fix the old README.md according to README.md template.
Can someone please review the patch.

Thank you for your support!!!

Status: Needs review » Needs work

The last submitted patch, 6: updated #6.patch, failed testing. View results

nitin_lama’s picture

Assigned: Unassigned » nitin_lama
nitin_lama’s picture

Assigned: nitin_lama » Unassigned
Status: Needs work » Needs review

Updated MR. Please review.

nupur badola’s picture

Reviewed MR!7, Patch is not cleanly applied.

a. In ##Use section, `calendar_link` given as twice with same marking as 1.
b.  Above ## Maintainers, Two lines prior are required.
avpaderno’s picture

Status: Needs review » Needs work

sakthi_dev made their first commit to this issue’s fork.

sakthi_dev’s picture

Status: Needs work » Needs review

Please review.

nupur badola’s picture

Status: Needs review » Needs work

Reviewed MR!7,

a) 7.diff.txt:151: trailing whitespace.
In a twig template file, the following code with generate a link to the event
warning: 1 line adds whitespace errors.

b) Two line prior to maintainer section is required.
avpaderno’s picture

Status: Needs work » Needs review
thakurnishant_06’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed the MR7 , added some minor update and rest of the changes looks Ok.
Moving to RTBC.
Thanks.

nupur badola’s picture

Status: Reviewed & tested by the community » Needs work

Still the issue exists:
1. Two line prior to "Maintainer" and "Configuration" section is required.

avpaderno’s picture

Status: Needs work » Needs review
nupur badola’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed MR!7, the file is updated as per the readme.md file template.
Hence marking it to RTBC.

wells made their first commit to this issue’s fork.

  • wells committed 8b5e4144 on 3.0.x authored by Sonal Gyanani
    Issue #3333147 by Sonal Gyanani, avpaderno, thakurnishant_06, nitin_lama...
wells’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.