Closed (fixed)
Project:
Calendar Link
Version:
3.0.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jan 2023 at 05:34 UTC
Updated:
21 Sep 2024 at 13:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
Sonal Gyanani commentedCreated MR for the issue according to Readme.md template format.
Please review.
Thanks
Comment #5
kavitha89 commentedWhen trying to apply the patch, the following can be observed:
7.patch:18: trailing whitespace.
# Calendar Link
7.patch:63: trailing whitespace.
library as its foundation. Use composer to install the module
7.patch:73: trailing whitespace.
- Install with composer to ensure dependencies are also installed:
7.patch:79: trailing whitespace.
- Install as you would normally install a contributed Drupal module. For
7.patch:112: trailing whitespace.
Returns an array of links for all available calendar types. Each
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Comment #6
thakurnishant_06 commentedHello Everyone !!
Created a #6 patch for calender link 3.0.x-dev. The patch successfully fix the old README.md according to README.md template.
Can someone please review the patch.
Thank you for your support!!!
Comment #8
nitin_lamaComment #9
nitin_lamaUpdated MR. Please review.
Comment #10
nupur badola commentedReviewed MR!7, Patch is not cleanly applied.
Comment #11
avpadernoComment #13
sakthi_dev commentedPlease review.
Comment #14
nupur badola commentedReviewed MR!7,
Comment #15
avpadernoComment #16
thakurnishant_06 commentedReviewed the MR7 , added some minor update and rest of the changes looks Ok.
Moving to RTBC.
Thanks.
Comment #17
nupur badola commentedStill the issue exists:
1. Two line prior to "Maintainer" and "Configuration" section is required.
Comment #18
avpadernoComment #19
nupur badola commentedReviewed MR!7, the file is updated as per the readme.md file template.
Hence marking it to RTBC.
Comment #22
wells