use_imagecache_root doesn't work with webp

tried applying the old patch. Are you saying that works?

If the webp generated images are available locally then the file_exists check returns TRUE and the the local image gets rendered but if the file has been uploaded and is supposed to render the first time then the webp file is not yet generated and the file_exists returns false and it redirects the url to remote.
This patch will check all the possible ext of images and if the image is found then it will not be a redirect and the local file is returned.

Just merged #3282542: Add a lock around retrieving upstream files could you test to see if you are still experiencing the issue on the dev branch?

The ProxySubscriber was deprecated in that merge.

I just tested webp images and they work fine for me. However, it's not yet configured using responsive images in case that has something to do with triggering the bug.

Opened https://git.drupalcode.org/project/stage_file_proxy/-/merge_requests/34 for a different approach of using a local file entity query to find a matching local file entity URI for the imagecache root.

Thank you @godotislate have you tried the latest 2.0.x dev branch to see if the issue still exits?

Sounds similar to the problem: https://www.drupal.org/project/stage_file_proxy/issues/3326961

So for patch #8 since it’s using a now deprecated approach can you test to see if the latest changes to 2.xdev fixes the issue

Same for the merge request. If the issue is still present then the MR needs to be rebased and then tested

Hey,

The problem with webp is that we don't give drupal the ability to generate the image, when we invert the arrays and call webp first, drupal will capture the missing image and generate it.

    // Webp support.
    if (str_ends_with($relative_path, '.webp')) {
      $paths[] = str_replace('.webp', '', $relative_path);
      $paths = array_reverse($paths);
    }

Before Revers :

['styles/medium/public/2023-01/1516934428429_5.jpg.webp ', 'styles/medium/public/2023-01/1516934428429_5.jpg'];

So we can do call first to image without webp and drupal has time for generate missing images.

@dziabodo

Thank you just want to confirm the MR and current 2.0.x-dev did not fix it for you?

Yeah @smustgrave, problem still existed, but after revers array images back

Thank you for checking. Can someone confirm if $17 solves the issues for them? DOn't have webP setup locally or on any projects.

#17 solved the issue for us but I do have to note that we are using core's built-in convert effect for WebP image styles and not the contributed module (as described in the original issue for WebP support linked in the IS).

Okay if no objection by tomorrow I'll merge in #17. Will track under the Meta if we can get plenty of testing.

Merged #17. If still an issue please reopen!

If we can get heavy testing could probably do another release for https://www.drupal.org/project/stage_file_proxy/issues/3334239

Wrong status.

Don't get how you guys got this to work, the checkFileOrigin method is looking for:

public://example.webp
public://example

Which nether exists because the webp is being created by the webp module as a image style and of course public://example does not exist.
Here is a patch that checks for other file extensions.
Btw im using responsive images, maybe thats why it does not work for me.

Would recommend opening a new ticket explaining your issue.