This module is still using old README.md template format in README.md file.

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#4 Bing_readme.PNG21.11 KBkavitha89

Issue fork bing_indexing_api-3332833

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !2

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Hi create MR for README.md file update.
Please review.
Thanks.

kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Bing_readme.PNG21.11 KB

The patch works fine and moving it to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.

nupur badola’s picture

nupur badola commented

Reviewed MR!3, The patch is not cleanly applied.

Below Name of the Sponsor should be present before "[Boehringer Ingelheim]"
This project has been sponsored by:
- [Boehringer Ingelheim](https://www.drupal.org/boehringer-ingelheim)
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs review » Reviewed & tested by the community

Hi I reviewed the MR.

Sounds good to me.

Readme is following drupal standards

All the required sections are cleanly described

Moving to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!2, 

1. The line in introduction is changed to "This module connects with Microsoft Bing Indexing API and updates search index
based on Drupal Page status (unpublish/deletion)."
2. Is it better to move "`https://www.drupal.org/project/issues/bing_indexing_api`
", into introduction section.
3. Sponsor are now in different section from maintainer.
4. Current maintainer text is removed from maintainer section.

Anna D made their first commit to this issue’s fork.

anna d’s picture

anna d commented
anna d’s picture

anna d commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.