We are blocked from upgrading to 9.4.9 because of the committed issue https://www.drupal.org/project/drupal/issues/2898903.

The line in question is https://git.drupalcode.org/project/drupal/-/blame/9.4.9/core/modules/tax...

We have 2 options, either submit an issue to remove the restriction with the `(int)` typecasting, or override this form part in rdf_term module.

Issue fork rdf_entity-3332666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

Title: Latest Taxonomy are breaking rdf_taxonomy » Latest core taxonomy changes are breaking rdf_taxonomy
claudiu.cristea’s picture

Status: Needs work » Needs review
StatusFileSize
new2.38 KB

A test-only patch to see the bug.

Status: Needs review » Needs work

The last submitted patch, 3: 3332666-prove-the-bug.patch, failed testing. View results

claudiu.cristea’s picture

Status: Needs work » Needs review
StatusFileSize
new2.75 KB

Improved "test only" patch.

Status: Needs review » Needs work

The last submitted patch, 5: 3332666-prove-the-bug.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

claudiu.cristea’s picture

Status: Needs work » Needs review
StatusFileSize
new3.71 KB

Trying to patch core.

claudiu.cristea’s picture

Still trying to patch the core.

claudiu.cristea’s picture

StatusFileSize
new4.94 KB
claudiu.cristea’s picture

StatusFileSize
new4.94 KB

Fix composer.json

claudiu.cristea’s picture

StatusFileSize
new4.93 KB

Fix starting directory.

claudiu.cristea’s picture

StatusFileSize
new4.78 KB

Remove dependency on composer-patches.

Status: Needs review » Needs work

The last submitted patch, 12: 3332666-12.patch, failed testing. View results

claudiu.cristea’s picture

Status: Needs work » Needs review

Ready for review.

claudiu.cristea’s picture

Note that this fix requires Drupal core patch from #3332877: Added TermForm::getParentIds for allowing to override in contrib

claudiu.cristea’s picture

I have no idea why started to fail with PHP 7.4 & MySQL 5.7, D9.5. I've tested locally with the same env and didn't manage to reproduce. Also... it passed before. I think it's safe to be merged with this failure as PHP7 is already EndOfLife

dimilias’s picture

Status: Needs review » Needs work

I would think that we can use a different way of handling this.
Your solution works but semantically, the http://www.w3.org/2004/02/skos/core#broaderTransitive predicate (which is the inverse predicate of http://www.w3.org/2004/02/skos/core#narrowerTransitive) should point to a resource.
That means that for the skos vocabulary, the '0' is not a valid value. This might create problems for us.

What we could use instead, is the base URI of the vocabulary, or the graph name or something. Explaining:
Usually, the vocabularies have a Scheme URI. Meaning that not only terms are having a URI, but the vocabulary as well.
For example, if a vocabulary has a base URL http://example.com/voc# then its terms should be

http://example.com/voc#term1
http://example.com/voc#term2
http://example.com/voc#term3

then we could use the http://example.com/voc# as the <root> term.

Otherwise, we could use some graph name, anyway, it is going to be a pseudo term.

claudiu.cristea’s picture

There's a weird thing going on with the PHP 8.1 & MySQL 8, D9.5 run. Somehow is installing easyrdf/easyrdf even the installed drupal/sparql_entity_storage is 2.0.0-alpha11 and that requires sweetrdf/easyrdf. This is very weird, looks like there's some Composer caching issue?

claudiu.cristea’s picture

Assigned: claudiu.cristea » Unassigned
Status: Needs work » Needs review

Ready for review

dimilias’s picture

Status: Needs review » Fixed

Thanks for the work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.