Closed (fixed)
Project:
RDF entity
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2023 at 15:46 UTC
Updated:
6 Feb 2023 at 16:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
claudiu.cristeaComment #3
claudiu.cristeaA test-only patch to see the bug.
Comment #5
claudiu.cristeaImproved "test only" patch.
Comment #7
claudiu.cristeaTrying to patch core.
Comment #8
claudiu.cristeaStill trying to patch the core.
Comment #9
claudiu.cristeaComment #10
claudiu.cristeaFix composer.json
Comment #11
claudiu.cristeaFix starting directory.
Comment #12
claudiu.cristeaRemove dependency on composer-patches.
Comment #15
claudiu.cristeaReady for review.
Comment #16
claudiu.cristeaNote that this fix requires Drupal core patch from #3332877: Added TermForm::getParentIds for allowing to override in contrib
Comment #17
claudiu.cristeaI have no idea why started to fail with PHP 7.4 & MySQL 5.7, D9.5. I've tested locally with the same env and didn't manage to reproduce. Also... it passed before. I think it's safe to be merged with this failure as PHP7 is already EndOfLife
Comment #18
dimilias commentedI would think that we can use a different way of handling this.
Your solution works but semantically, the
http://www.w3.org/2004/02/skos/core#broaderTransitivepredicate (which is the inverse predicate ofhttp://www.w3.org/2004/02/skos/core#narrowerTransitive) should point to a resource.That means that for the skos vocabulary, the
'0'is not a valid value. This might create problems for us.What we could use instead, is the base URI of the vocabulary, or the graph name or something. Explaining:
Usually, the vocabularies have a
SchemeURI. Meaning that not only terms are having a URI, but the vocabulary as well.For example, if a vocabulary has a base URL
http://example.com/voc#then its terms should bethen we could use the
http://example.com/voc#as the<root>term.Otherwise, we could use some graph name, anyway, it is going to be a pseudo term.
Comment #19
claudiu.cristeaThere's a weird thing going on with the PHP 8.1 & MySQL 8, D9.5 run. Somehow is installing
easyrdf/easyrdfeven the installeddrupal/sparql_entity_storageis2.0.0-alpha11and that requiressweetrdf/easyrdf. This is very weird, looks like there's some Composer caching issue?Comment #20
claudiu.cristeaReady for review
Comment #22
dimilias commentedThanks for the work.