Problem/Motivation

More projects will be moved to Drupal 10 moving forward so it would be good if the module could be updated accordingly.

Steps to reproduce

Check the module status using upgrade-status - this shows that the module is not compatible with Drupal 10 yet.

Proposed resolution

Update the module code and yml files to support Drupal 10.

Issue fork commerce_webform_order-3332552

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roaldnel created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -ProjectUpdateBotD10

davisben made their first commit to this issue’s fork.

davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Assigned: Unassigned » davisben

I'll be working on this.

davisben opened merge request !3

davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Assigned: davisben » Unassigned
Status: Active » Needs review
johan den hollander’s picture

johan den hollander commented

Great work @davisben.
I just applied the plain diff and the Upgrade scanner says it's compatible with Drupal 10!

However 1 warning is still given in: web/modules/contrib/commerce_webform_order/commerce_webform_order.install - line 46

Call to deprecated method prepare() of class Drupal\Core\Database\Connection. Deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Database drivers should instantiate \PDOStatement objects by calling \PDO::prepare in their Connection::prepareStatement method instead. \PDO::prepare should not be called outside of driver code.

davisben’s picture

davisben
Primary language English
Location NH, USA
commented

Good catch! That has also been updated now.

johan den hollander’s picture

johan den hollander commented
Status: Needs review » Reviewed & tested by the community

Thanks. That makes sure the last warning is gone.
Now let's hope this will make it into a new release!

maris.abols’s picture

maris.abols commented

Any update on this topic? When it is planned to merge https://git.drupalcode.org/project/commerce_webform_order/-/merge_reques... ? It seems ready!

boby_ui’s picture

boby_ui commented

+1 on getting it to merge please

  • facine committed a0ff7b5d on 3.x authored by davisben 
    Issue #3332552 by davisben, apaderno, Johan den Hollander: Drupal 10...
facine’s picture

facine commented
Status: Reviewed & tested by the community » Fixed

Thank you all very much, I just merge it.

facine closed merge request !3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.