The current tests show the following output with PHP 8.2:

Views Plugins.Views Plugins
1	1	Views Plugins.viewsPluginStyleJumpMenuTest
✓		- setUp
✗	
testDuplicatePaths
fail: [Other] Line 70 of sites/all/modules/views/tests/styles/views_plugin_style_jump_menu.test:
Title   
          z7VWX4cu   should appear on the jump list, as we do not filter

fail: [Other] Line 70 of sites/all/modules/views/tests/styles/views_plugin_style_jump_menu.test:
Title   
          clMqiqxh   should appear on the jump list, as we do not filter

fail: [Other] Line 70 of sites/all/modules/views/tests/styles/views_plugin_style_jump_menu.test:
Title   
          tIgSxthI   should appear on the jump list, as we do not filter

fail: [Other] Line 70 of sites/all/modules/views/tests/styles/views_plugin_style_jump_menu.test:
Title   
          tkEBpGUh   should appear on the jump list, as we do not filter
CommentFileSizeAuthor
#5 views-jump_menu_php82-3332486-5.patch929 bytestibezh

Issue fork views-3332486

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@DamienMcKenna, please add PHP 8.1 to the automated tests.
and maybe set PHP 8.0 or 8.1 as the default as 7.4 is EOL since december 2022.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I switched the default test run to PHP 8.0. Once we fix the PHP 8.2 tests I'll update the tests to use it. IMHO adding 8.1 would be a wasted effort.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Closed (duplicate)
Parent issue: #3328032: Plan for Views 7.x-3.29 » #3336764: PHP 8.x deprecated function warning at runtime

This should be fixed in #3336764: PHP 8.x deprecated function warning at runtime

tibezh’s picture

tibezh commented
Assigned: Unassigned » tibezh
Status: Closed (duplicate) » Active
StatusFileSize
new views-jump_menu_php82-3332486-5.patch929 bytes

I can see that the issue is still present, seems the patch should be fix the issue.

tibezh’s picture

tibezh commented
Assigned: tibezh » Unassigned
Status: Active » Needs review

It looks good now, needs review.

tibezh opened merge request !12

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

OK, interesting that the sorting direction fixes the tests? But if we are green now on all PHP versions this is fine!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3336764: PHP 8.x deprecated function warning at runtime » #3347650: Plan for Views 7.x-3.30
Related issues: +#3336764: PHP 8.x deprecated function warning at runtime

Thanks for fixing the test coverage. Let's add this to the next release.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@tibezh, thanks for this fix, which , for whatever reason I've never understood why and how this is a fix but I've seen PHP 8.2 issues related to this before. Your very small change does fix the test and amazingly doesn't cause a test failure in the other versions of PHP (confusing me even more).

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@DamienMcKenna, you'll also want to commit this fix, also by @tibezh
#3409931: Views plugin query: TypeError: explode(): Argument #2 ($string) must be of type string

  • DamienMcKenna committed 553ff357 on 7.x-3.x authored by tibezh 
    Issue #3332486 by tibezh, DamienMcKenna, joseph.olstad, klausi: Fix PHP...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Fix PHP 8.2 bug in jump menu » Fix PHP 8.2 bug in jump menu tests
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.