Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Fix issue on full calendar plugin to check if $calendar_options['events'] isset
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | smart_date-fullcalendar_view_check_if_events_set-3332275-3.patch | 810 bytes | mandclu |
| #2 | 3332275-2.patch | 2.94 KB | qusai taha |
Comments
Comment #2
qusai taha commentedComment #3
mandclu commentedThanks for identifying this. It would be better if there were detailed steps to reproduce, but checking that something isset before attempting to use it is a solid best practice anyway.
Given that the key change is being proposed is to check if the array key isset, I would propose instead to do this as a separate check before attempting to assign it to the $entries variable. It makes for more readable code, as well as making the diff in the proposed change much easier to understand.
Please let me know if this updated patch resolves your issue and I'll be happy to get this merged in.
Comment #5
mandclu commentedMerged in the change proposed in #3. Closing this issue but feel free to reopen it if additional work is needed.
Comment #6
mandclu commented