Problem/Motivation

Due to #3331835: Some JavaScript errors are not recorded during test runs it wasn't possible to commit test cases in #3305706: Uncaught TypeError: this.$pluginSelect.find(...)[0] is undefined in a timely manner. Hence, they are postponed in this issue until #3331835: Some JavaScript errors are not recorded during test runs has landed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3332148-test-cases-for-2.patch3.14 KBznerol

Comments

znerol created an issue. See original summary.

znerol’s picture

Status: Active » Needs review
StatusFileSize
new3.14 KB
znerol’s picture

Title: Test cases for extra field drag&drop issue » [PP-1] Test cases for extra field drag&drop issue
Status: Needs review » Postponed
spokje’s picture

To prevent code-duplication, perhaps we could do something like

diff --git a/core/modules/field_ui/tests/src/FunctionalJavascript/EntityDisplayTest.php b/core/modules/field_ui/tests/src/FunctionalJavascript/EntityDisplayTest.php
+  /**
+   * Tests drag&drop of an extra field from hidden to content area.
+   *
+   * @param string $table_drag_selector
+   *   The table drag selector of the extra field.
+   */
+  public function testHiddenExtraFields(string $table_drag_selector = ''): void {
+    if ($table_drag_selector === '') {
+      $table_drag_selector = '.handle';
+    }
+
+   [testy-test]
+  }

diff --git a/core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroEntityDisplayTest.php b/core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroEntityDisplayTest.php

+  /**
+   * {@inheritdoc}
+   */
+  public function testHiddenExtraFields(string $table_drag_selector = ''): void {
+    parent::testHiddenExtraFields('.js-tabledrag-handle');
+  }
+


Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.