Problem/Motivation

Upgraded to 3.x-dev (1/6/23) and got this error:

ParseError: syntax error, unexpected '->' (T_OBJECT_OPERATOR) in Composer\Autoload\includeFile() (line 181 of /mysite/modules/contrib/geolocation/src/Plugin/views/filter/ProximityFilter.php) 

src/Plugin/views/filter/ProximityFilter.php:179:    $views_session = $session?->get('views', []) ?? [];
src/Plugin/views/filter/ProximityFilter.php:187:    $session?->set('views', $views_session);

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3331779--proximity-filter-php7.patch1.05 KBchristianadamski
#2 3331779-remove-syntax-error.patch1.01 KBsocialnicheguru

Comments

SocialNicheGuru created an issue. See original summary.

socialnicheguru’s picture

socialnicheguru commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3331779-remove-syntax-error.patch1.01 KB
christianadamski’s picture

christianadamski commented
Status: Needs review » Postponed (maintainer needs more info)

Hmm. My notation is PHP 8. Are you using PHP 7.4?

socialnicheguru’s picture

socialnicheguru commented

yes I am on php7.4.
so should the new version explicitly enforce php8?
is there a way for it to support both php8 and php7.4+?

socialnicheguru’s picture

socialnicheguru commented
Status: Postponed (maintainer needs more info) » Needs work
christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 3331779--proximity-filter-php7.patch1.05 KB

$session can be null. Different issue here somewhere. That's why your patch can't stand as is.

This patch should do it.

Note that Drupal 10 needs PHP8.

  • SocialNicheGuru authored aa69e7b1 on 8.x-3.x 
    Issue #3331779 by SocialNicheGuru, ChristianAdamski: Incorrect syntax...
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.