Problem/Motivation

  • Comply with Drupal coding standards.
CommentFileSizeAuthor
#11 3331666-11.patch28.52 KByas

Issue fork cloud-3331666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1518

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Comply with Drupal coding standards (25) » Comply with Drupal coding standards (26)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the refactoring. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed fb331989 on 5.x authored by sekinet 
    Issue #3331666 by sekinet, yas: Comply with Drupal coding standards (26)

  • yas committed 0f3f6526 on 4.x authored by sekinet 
    Issue #3331666 by sekinet, yas: Comply with Drupal coding standards (25)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Fixed » Needs work

@sekinet

Sorry, the patch should be reverted in order to match the latest release of drupal/coder:8.3.16. I'll take care of the revert.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3331666-11.patch28.52 KB

Here is the patch to revert.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all, @sekinet

The tests has been passed successfully, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 5d08fc4f on 5.x 
    Issue #3331666 by yas: Revert: Comply with Drupal coding standards (26)

  • yas committed fda2fd73 on 4.x 
    Issue #3331666 by yas: Revert: Comply with Drupal coding standards (25)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.