Fix the issues reported by phpcs [#3331519]

Problem/Motivation

Getting following errors and warning

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pagerer/ 

FILE: pagerer/pagerer_example/pagerer_example.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 9 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------


FILE: pagerer/pagerer_example/src/Controller/PagererExampleController.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------
 20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 71 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------


FILE: pagerer/tests/modules/pagerer_test/pagerer_test.module
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
 18 | WARNING | Unused variable $index.
----------------------------------------------------------------------------------


FILE: pagerer/tests/src/Functional/PagererTest.php
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
 570 | WARNING | Unused variable $match_querystring.
------------------------------------------------------------------------


FILE: pagerer/tests/src/FunctionalJavascript/CorePagerReplacePaginationAJAXTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 32 WARNINGS AFFECTING 32 LINES
----------------------------------------------------------------------
  38 | WARNING | Line exceeds 80 characters; contains 81 characters
  51 | WARNING | Line exceeds 80 characters; contains 93 characters
  57 | WARNING | Line exceeds 80 characters; contains 83 characters
  58 | WARNING | Line exceeds 80 characters; contains 85 characters
 256 | WARNING | Line exceeds 80 characters; contains 82 characters
 265 | WARNING | Line exceeds 80 characters; contains 81 characters
 281 | WARNING | Line exceeds 80 characters; contains 84 characters
 286 | WARNING | Line exceeds 80 characters; contains 81 characters
 313 | WARNING | Line exceeds 80 characters; contains 82 characters
 320 | WARNING | Line exceeds 80 characters; contains 82 characters
 328 | WARNING | Line exceeds 80 characters; contains 85 characters
 331 | WARNING | Line exceeds 80 characters; contains 83 characters
 340 | WARNING | Line exceeds 80 characters; contains 82 characters
 344 | WARNING | Line exceeds 80 characters; contains 83 characters
 351 | WARNING | Line exceeds 80 characters; contains 83 characters
 354 | WARNING | Line exceeds 80 characters; contains 83 characters
 361 | WARNING | Line exceeds 80 characters; contains 81 characters
 363 | WARNING | Line exceeds 80 characters; contains 81 characters
 365 | WARNING | Line exceeds 80 characters; contains 87 characters
 368 | WARNING | Line exceeds 80 characters; contains 97 characters
 374 | WARNING | Line exceeds 80 characters; contains 87 characters
 379 | WARNING | Line exceeds 80 characters; contains 87 characters
 382 | WARNING | Line exceeds 80 characters; contains 81 characters
 384 | WARNING | Line exceeds 80 characters; contains 81 characters
 391 | WARNING | Line exceeds 80 characters; contains 81 characters
 394 | WARNING | Line exceeds 80 characters; contains 81 characters
 403 | WARNING | Line exceeds 80 characters; contains 82 characters
 405 | WARNING | Line exceeds 80 characters; contains 84 characters
 432 | WARNING | Line exceeds 80 characters; contains 84 characters
 435 | WARNING | Line exceeds 80 characters; contains 81 characters
 444 | WARNING | Line exceeds 80 characters; contains 83 characters
 463 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: pagerer/interdiff_21-22.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
  25 | WARNING | Line exceeds 80 characters; contains 99 characters
  33 | WARNING | Line exceeds 80 characters; contains 81 characters
  58 | WARNING | Line exceeds 80 characters; contains 132 characters
  66 | WARNING | Line exceeds 80 characters; contains 92 characters
  69 | WARNING | Line exceeds 80 characters; contains 172 characters
  84 | WARNING | Line exceeds 80 characters; contains 81 characters
  88 | WARNING | Line exceeds 80 characters; contains 97 characters
 112 | WARNING | Line exceeds 80 characters; contains 116 characters
 120 | WARNING | Line exceeds 80 characters; contains 131 characters
 145 | WARNING | Line exceeds 80 characters; contains 81 characters
 164 | WARNING | Line exceeds 80 characters; contains 85 characters
 175 | WARNING | Line exceeds 80 characters; contains 151 characters
----------------------------------------------------------------------


FILE: pagerer/pagerer.module
---------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------
   1 | ERROR | [x] Missing file doc comment
 103 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 173 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: pagerer/interdiff_19-21.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  43 | WARNING | Line exceeds 80 characters; contains 81 characters
  56 | WARNING | Line exceeds 80 characters; contains 81 characters
 198 | WARNING | Line exceeds 80 characters; contains 81 characters
 225 | WARNING | Line exceeds 80 characters; contains 81 characters
 234 | WARNING | Line exceeds 80 characters; contains 151 characters
----------------------------------------------------------------------


FILE: pagerer/src/Entity/PagererPreset.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 84 | ERROR | [x] list(...) is forbidden, use [...] instead.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: pagerer/src/PagererManager.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManager.
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Form/PagererConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManagerInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Form/PagererPresetEditForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
 191 | ERROR | The array declaration extends to column 129 (the limit is 120). The array content should be split up over multiple lines
 196 | ERROR | The array declaration extends to column 130 (the limit is 120). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/PagererStyleBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/Adaptive.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 125 | ERROR | The array declaration extends to column 132 (the limit is 120). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/Multipane.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\pagerer\Entity\PagererPreset.
 73 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 74 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 75 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 89 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/PagererStyleManager.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 18 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: pagerer/src/PagererPresetListBuilder.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityHandlerInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run following command:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pagerer/

Proposed resolution

Run following command:

phpcbf --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pagerer

and do more changes as per requirement.

Comment	File	Size	Author
#22	interdiff_21-22.txt	7.28 KB	nikolay shapovalov
#22	3331519-22.patch	32.53 KB	nikolay shapovalov
#21	interdiff_19-21.txt	12.76 KB	nikolay shapovalov
#21	3331519-21.patch	33.83 KB	nikolay shapovalov
#19	interdiff_17-19.txt	9.69 KB	adwivedi008
#19	3331519-19.patch	32.76 KB	adwivedi008
#17	interdiff-11_17.txt	25.68 KB	urvashi_vora
#17	3331519-17.patch	22.66 KB	urvashi_vora
#11	interdiff_3-11.txt	19.63 KB	akram khan
#11	3331519-11.patch	27.47 KB	akram khan
#9	interdiff_3-9.txt	25.25 KB	hardikpandya
#9	3331519-9.patch	32.28 KB	hardikpandya
#5	pagerer.png	103.12 KB	atul_ghate
#3	3331519-3.patch	8.11 KB	shivam-kumar
#2	3331519-2.patch	8.76 KB	shivam-kumar

Issue fork pagerer-3331519

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3331519-fix-the-issues changes, plain diff MR !19
Check out this branch for the first time

Check out existing branch, if you already have it locally
3331519-fix-phpstan-lint compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

test_phpunit

changes, plain diff MR !20

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

6 January 2023 at 12:09

shivam-kumar created an issue. See original summary.

Comment #2

shivam-kumar commented 6 January 2023 at 12:22

Assigned:	shivam-kumar	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	3331519-2.patch	8.76 KB

Fixed the above errors,some phpcs errors needs to be fixed.

Comment #3

shivam-kumar commented 9 January 2023 at 12:49

Status	File	Size
new	3331519-3.patch	8.11 KB

Updated patch to resolve above upcoming Issue.

Comment #4

atul_ghate commented 9 January 2023 at 13:50

Assigned:

Unassigned

» atul_ghate

I will review this patch.

Comment #5

atul_ghate commented 9 January 2023 at 17:27

Assigned:	atul_ghate	» Unassigned
Status:	Needs review	» Needs work

Status	File	Size
new	pagerer.png	103.12 KB

The patch has been reviewed and applied cleanly, but a few phpcs still remain

Comment #6

Neeraj333 commented 18 January 2023 at 13:40

Assigned:

Unassigned

» Neeraj333

Comment #7

Neeraj333 commented 19 January 2023 at 04:23

Assigned:

Neeraj333

» Unassigned

Comment #8

hardikpandya commented 19 January 2023 at 06:30

Assigned:

Unassigned

» hardikpandya

Status	File	Size
new	3331519-9.patch	32.28 KB
new	interdiff_3-9.txt	25.25 KB

Comment #10

20 January 2023 at 06:28

Status:

Needs review

» Needs work

The last submitted patch, 9: 3331519-9.patch, failed testing. View results

Status	File	Size
new	3331519-11.patch	27.47 KB
new	interdiff_3-11.txt	19.63 KB

Comment #12

20 February 2023 at 05:59

Status:

Needs review

» Needs work

The last submitted patch, 11: 3331519-11.patch, failed testing. View results

Comment #13

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 20 February 2023 at 21:16

Title:	Drupal Coding Standards Issues \| phpcs	» Fix the issues reported by phpcs
Version:	3.0.0	» 3.0.x-dev
Category:	Bug report	» Task
Priority:	Minor	» Normal

Comment #14

22 February 2023 at 07:48

vishaljd made their first commit to this issue’s fork.

Comment #15

vishaljd commented 22 February 2023 at 07:49

Assigned:

Unassigned

» vishaljd

Comment #16

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 22 February 2023 at 12:01

Assigned:

vishaljd

» Unassigned

Status	File	Size
new	3331519-17.patch	22.66 KB
new	interdiff-11_17.txt	25.68 KB

Comment #18

24 March 2023 at 12:24

Status:

Needs review

» Needs work

The last submitted patch, 17: 3331519-17.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #19

adwivedi008 commented 6 November 2023 at 12:37

Status:	Needs work	» Needs review
Issue tags:		+Coding standards, +Dependency Injection (DI)

Status	File	Size
new	3331519-19.patch	32.76 KB
new	interdiff_17-19.txt	9.69 KB

Revised patch #18 and fixed remaining issues

FILE: pagerer/pagerer_example/src/Controller/PagererExampleController.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
 20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 71 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------


FILE: pagerer/pagerer.module
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
 108 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 178 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: pagerer/src/Form/PagererConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManagerInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Entity/PagererPreset.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 84 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: pagerer/src/PagererPresetListBuilder.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityHandlerInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/PagererStyleBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/Plugin/pagerer/Multipane.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\pagerer\Entity\PagererPreset.
 73 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 74 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 75 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 89 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: pagerer/src/PagererManager.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Pager\PagerManager.
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

Time: 473ms; Memory: 18MB

Comment #20

6 November 2023 at 12:41

Status:

Needs review

» Needs work

The last submitted patch, 19: 3331519-19.patch, failed testing. View results

Comment #21

nikolay shapovalov commented 13 November 2023 at 12:30

Status:

Needs work

» Needs review

Status	File	Size
new	3331519-21.patch	33.83 KB
new	interdiff_19-21.txt	12.76 KB

Thanks @adwivedi008 for you contribution,
Please double check that you remove trailing whitespaces.
I added StringTranslationTrait in test file and removed trailing whitespaces.

Comment #22

nikolay shapovalov commented 18 November 2023 at 03:22

Status	File	Size
new	3331519-22.patch	32.53 KB
new	interdiff_21-22.txt	7.28 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	3331519-21.patch	33.83 KB
hidden	interdiff_19-21.txt	12.76 KB

Made review of patch from #21.
Here is updated patch.

Comment #23

18 November 2023 at 03:33

zniki.ru opened merge request !19

Comment #24

nikolay shapovalov commented 18 November 2023 at 03:36

12 files were hidden/shown/deleted

Status	File	Size
hidden	3331519-2.patch	8.76 KB
hidden	3331519-3.patch	8.11 KB
hidden	3331519-9.patch	32.28 KB
hidden	interdiff_3-9.txt	25.25 KB
hidden	3331519-11.patch	27.47 KB
hidden	interdiff_3-11.txt	19.63 KB
hidden	3331519-17.patch	22.66 KB
hidden	interdiff-11_17.txt	25.68 KB
hidden	3331519-19.patch	32.76 KB
hidden	interdiff_17-19.txt	9.69 KB
hidden	3331519-22.patch	32.53 KB
hidden	interdiff_21-22.txt	7.28 KB

Create MR 19 to use gitlab ci.
Hide all patch files.

Comment #25

nikolay shapovalov commented 18 November 2023 at 03:40

Issue summary:

View changes

Update Issue summary, update phpcs violations.

Comment #26

18 November 2023 at 05:35

zniki.ru opened merge request !20

Comment #27

18 November 2023 at 05:49

zniki.ru closed merge request !20

Comment #28

nikolay shapovalov commented 19 November 2023 at 04:30

I create separate MR to test fixes for eslint, phpstan, stylelint.
https://git.drupalcode.org/issue/pagerer-3331519/-/merge_requests/2

Updated: MR is closed, future work happens in #3402666

Comment #29

mondrake

🇮🇹

commented 19 November 2023 at 13:20

Status:

Needs review

» Needs work

Thanks for working on this. I agree, let's only do PHPCS fixes in this issue.

I just added more configuration for GitlabCI testing - phpstan.neon and phpcs.xml.dist. PHPCS is now configured to skip README.md, so I would not touch that here.

Also, I dropped all DrupalCI configration and testing.

Comment #30

nikolay shapovalov commented 19 November 2023 at 16:20

Status:

Needs work

» Needs review

Thanks for the feedback and changes you made.
I created separate issue #3402666 to work on PHPStan, eslint, stylelint.

@mondrake do you want to remove changes in README.md file.
We already made some changes in this file and I think we can keep it even the file will be excluded from code style check in the future.
What do you think?

I don't see other things that needs to be done for this issue, there is no phpcs violations left. Please let me know if I miss something?

Comment #31

mondrake

🇮🇹

commented 19 November 2023 at 21:23

Status:

Needs review

» Needs work

Thanks! I made some comments inline the MR, that need work. For README.md, OK to keep, but please let's make sure that if we make changes because of the 80 chars limit per line, each changed line gets as close as possible to 80 chars.

Comment #32

nikolay shapovalov commented 20 November 2023 at 02:52

Assigned:

Unassigned

» nikolay shapovalov

Thanks for feedback.

Comment #33

nikolay shapovalov commented 20 November 2023 at 03:40

Assigned:	nikolay shapovalov	» Unassigned
Status:	Needs work	» Needs review

I changed my mind about README.md, I think we can keep it without changes.
I updated MR, and removed changes for README.md file, and left only fix for it.

Comment #34

mondrake

🇮🇹

commented 20 November 2023 at 18:35

Status:

Needs review

» Needs work

Very close! Thanks for your work.

Comment #35

nikolay shapovalov commented 20 November 2023 at 19:24

Status:

Needs work

» Needs review

Thanks for a review. I made suggested changes. MR is ready for review.

Comment #36

mondrake

🇮🇹

commented 20 November 2023 at 20:54

This is first time I see this readonly property, I will not argue, fixed.

Drupal core is slowly introducing this. See for example #1014086-368: Stampedes and cold cache performance issues with css/js aggregation.

Comment #37

mondrake

🇮🇹

commented 20 November 2023 at 20:55

Credit.

Comment #38

20 November 2023 at 20:56

mondrake committed 768f39cd on 3.0.x authored by zniki.ru

Issue #3331519 by zniki.ru, shivam-kumar, hardikpandya, Akram Khan,...

Comment #39

mondrake

🇮🇹

commented 20 November 2023 at 20:56

Merged. Thank you!!

Comment #40

mondrake

🇮🇹

commented 20 November 2023 at 20:57

Status:

Needs review

» Fixed

Comment #41

4 December 2023 at 20:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.