PHPCS reported the following errors and warnings:

FILE: /banana_dashboard/css/banana_dashboard.css
----------------------------------------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 29 LINES
----------------------------------------------------------------------------------------------------------
  2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 43 | ERROR | [x] Expected 1 newline at end of file; 2 found
 44 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /banana_dashboard/src/Controller/BananaDashboardController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
 22 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 39 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
CommentFileSizeAuthor
#7 updated-14854085.patch6.93 KBatul_ghate
#6 14854085.patch6.93 KBatul_ghate
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

SolimanHarkas created an issue. See original summary.

atul_ghate’s picture

Assigned: Unassigned » atul_ghate

I will work on this issue.

solimanharkas’s picture

Status: Active » Needs review

sorry @atul-ghate I did not see your comment, I already created a Merge request.
maybe could you review it or if you want to create another one, it is also fine for me to review it.
Thank you a lot

atul_ghate’s picture

Assigned: atul_ghate » Unassigned

@SolimanHarkas, that's fine,
I'll review this patch.

atul_ghate’s picture

StatusFileSize
new6.93 KB

After reviewing and applying your patch, the majority of the PHPcs have been fixed, but some remain, so I'm providing another patch here, please review it

atul_ghate’s picture

StatusFileSize
new6.93 KB

Please ignore patch #6

d34dman’s picture

Hi, @soliman and @atul thanks for the MR and patches, really appreciated.

Atul, could you please let us know what changed between #3 and #7?

d34dman’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.