PHPCS reported the following errors and warnings:
FILE: /banana_dashboard/css/banana_dashboard.css
----------------------------------------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 29 LINES
----------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Expected 1 newline at end of file; 2 found
44 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------
FILE: /banana_dashboard/src/Controller/BananaDashboardController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
22 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
39 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | updated-14854085.patch | 6.93 KB | atul_ghate |
| #6 | 14854085.patch | 6.93 KB | atul_ghate |
Issue fork banana_dashboard-3331052
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
atul_ghate commentedI will work on this issue.
Comment #4
solimanharkas commentedsorry @atul-ghate I did not see your comment, I already created a Merge request.
maybe could you review it or if you want to create another one, it is also fine for me to review it.
Thank you a lot
Comment #5
atul_ghate commented@SolimanHarkas, that's fine,
I'll review this patch.
Comment #6
atul_ghate commentedAfter reviewing and applying your patch, the majority of the PHPcs have been fixed, but some remain, so I'm providing another patch here, please review it
Comment #7
atul_ghate commentedPlease ignore patch #6
Comment #8
d34dman commentedHi, @soliman and @atul thanks for the MR and patches, really appreciated.
Atul, could you please let us know what changed between #3 and #7?
Comment #10
d34dman commented