Follow the pattern in the README.md template.

CommentFileSizeAuthor
#2 3330966-2.patch3.34 KBnoorulshameera

Issue fork field_menu-3330966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

noorulshameera created an issue. See original summary.

noorulshameera’s picture

noorulshameera commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3330966-2.patch3.34 KB

Adding patch for README.md file.

ressa’s picture

ressa
he/him
commented
Version: 2.0.0 » 2.0.1
Issue summary: View changes
Status: Needs review » Needs work

Thanks, please follow the pattern under "README format" in the README.md template.

Please create an issue fork (click "Create issue fork") and commit to that, for easier preview and commenting.

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Unassigned » Sonal Gyanani

Sonal Gyanani opened merge request !3

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Sonal Gyanani » Unassigned
Status: Needs work » Needs review

Created merge request and fix issues.
Please review

ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks, looks pretty good.

This:

- code-brighton - [@code-brighton](https://www.drupal.org/u/code-brightoni))
- hdotnet - [@hdotnet](https://www.drupal.org/u/hdotnet))

Should be:

- code-brighton - [code-brighton](https://www.drupal.org/u/code-brighton)
- hdotnet - [hdotnet](https://www.drupal.org/u/hdotnet)
Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs work » Needs review

Thanks @ressa, fixed issue.
Please review

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Needs work

Maintainers URL is fount to 404.

Manoj Raj.R opened merge request !4

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review

Updated the MR with correct URL of Maintainers.

Created MR based on the branch to merge in 2x.

Please review

code-brighton made their first commit to this issue’s fork.

code-brighton’s picture

code-brighton commented
Status: Needs review » Reviewed & tested by the community

Thanks for the work @manoj-rajr and @sonal-gyanani

code-brighton’s picture

code-brighton commented
Status: Reviewed & tested by the community » Fixed

Fixed in 2.1.0 https://www.drupal.org/project/field_menu/releases/2.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.