Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3329932-2.patch1.38 KBshubham rathore

Issue fork notifybar-3329932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Shubham Rathore created an issue. See original summary.

shubham rathore’s picture

Assigned: shubham rathore » Unassigned
Status: Active » Needs review
StatusFileSize
new1.38 KB

Hi please review patch
Thank You

ressa’s picture

Status: Needs review » Needs work

Thanks, looks great!

It's true that the README.md guidelines used to say "Two lines prior to headings (except the first one)"

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

But the intention is, that at the very top it should be like this, with only a single line after the project name:

# Notifybar

## Table of contents

- Introduction
[...]

I have updated the guidelines to "Two lines prior to ## headings, but only one line after project name" to try to make it clearer what the intended formatting is.

Also, perhaps you can create an issue fork (click "Create issue fork") and commit to that, for easier preview and commenting?

Dheeraj Jhamtani made their first commit to this issue’s fork.

dheeraj jhamtani’s picture

Assigned: Unassigned » dheeraj jhamtani

ressa’s picture

Thanks @Dheeraj Jhamtani, looking good. I added a few comments.

heni_deepak made their first commit to this issue’s fork.

dheeraj jhamtani’s picture

Assigned: dheeraj jhamtani » Unassigned
Status: Needs work » Needs review
ressa’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @Dheeraj Jhamtani, looks good! Please resolve my comments currently marked "✗ unresolved".

anoopsingh92’s picture

Merge blocked: the source branch must be rebased onto the target branch.

Please rebase it

The source branch is 2 commits behind the target branch
1 commit will be added to 1.0.x.
Source branch will not be deleted.

  • heni_deepak committed 9b88e368 on 1.0.x
    git commit -m 'Issue #3329932 by heni_deepak, Dheeraj Jhamtani, Shubham...
heni_deepak’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.