Closed (fixed)
Project:
Notifybar
Version:
1.0.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2022 at 09:54 UTC
Updated:
24 Jan 2023 at 10:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shubham rathore commentedHi please review patch
Thank You
Comment #3
ressaThanks, looks great!
It's true that the README.md guidelines used to say "Two lines prior to headings (except the first one)"
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
But the intention is, that at the very top it should be like this, with only a single line after the project name:
I have updated the guidelines to "Two lines prior to
##headings, but only one line after project name" to try to make it clearer what the intended formatting is.Also, perhaps you can create an issue fork (click "Create issue fork") and commit to that, for easier preview and commenting?
Comment #5
dheeraj jhamtani commentedComment #7
ressaThanks @Dheeraj Jhamtani, looking good. I added a few comments.
Comment #9
dheeraj jhamtani commentedComment #10
ressaThanks @Dheeraj Jhamtani, looks good! Please resolve my comments currently marked "✗ unresolved".
Comment #11
anoopsingh92Please rebase it
Comment #13
heni_deepak commented