Problem/Motivation

Add README.md

Follow the pattern in the README.md template.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Shubham Rathore created an issue. See original summary.

shubham rathore’s picture

Assigned: shubham rathore » Unassigned
Status: Active » Needs review
StatusFileSize
new1.02 KB

Please review this patch.

ressa’s picture

Thanks, looks fine! See my comment about one line after project name in #3329932: Missing README.md file.

ressa’s picture

Status: Needs review » Needs work

Dheeraj Jhamtani made their first commit to this issue’s fork.

dheeraj jhamtani’s picture

Assigned: Unassigned » dheeraj jhamtani
Status: Needs work » Needs review

Thanks @ressa all issue fix

ressa’s picture

Assigned: dheeraj jhamtani » Unassigned
Status: Needs review » Needs work

Thanks, but I think you need to add the changes to this branch?

https://git.drupalcode.org/issue/page_body_attributes-3329924/-/tree/332...

heni_deepak’s picture

Status: Needs work » Needs review
Paulo Antonio Vital’s picture

Assigned: Unassigned » Paulo Antonio Vital

I will do a review

Paulo Antonio Vital’s picture

Assigned: Paulo Antonio Vital » Unassigned
Status: Needs review » Needs work

I was able to apply the path #9.
The path was applied very cleanly.
I have all the informations requireds about this module.
Just one thing the instalation section is before requirements section in Drupal coding standards it is wrong.

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Jitendra_Kumar’s picture

Status: Needs work » Needs review
StatusFileSize
new1.05 KB

Thanks, @Paulo Antonio Vital, I updated patch #2 according to the document.
Please review this patch
Thanks

ressa’s picture

Issue summary: View changes
Status: Needs review » Needs work

Thanks @Jitendra_Kumar, but any changes should be made to the branch created in #9 by @Dheeraj Jhamtani:

https://git.drupalcode.org/issue/page_body_attributes-3329924/-/tree/332...

For Git access, see https://www.drupal.org/docs/develop/git/setting-up-git-for-drupal/obtain...

After you get Git access, click "Get push access" and you should be able to edit the branch in Gitlab.

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani’s picture

Status: Needs work » Needs review
ressa’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @Sonal Gyanani, looks good.

Please close MR#2: https://git.drupalcode.org/project/page_body_attributes/-/merge_requests/2

EDIT: I mixed it up, sorry. The creator of MR#2 is @Dheeraj Jhamtani.

anoopsingh92’s picture

Someone has created an MR!2 against 1.0.x branch.

1.0.x Comparechanges, plain diff MR !2 merge error

We need to close this MR!2 just because this MR is not mergeable and there are no file changes and the second one is MR created directly against main branch 1.0.x.

MR!1 is good to me. We can go ahead with that.

Thank you

anoopsingh92’s picture

I tried to close this MR @ressa, but I am getting 404 when I close this MR. I think the maintainer can close this MR or creator also close this MR.

Thanks for catching this problem @ressa.

ressa’s picture

@anoopsingh92: Thanks for the feedback. And you're correct, I believe only the creator (@Dheeraj Jhamtani) of MR#2 can close it, or the maintainer.

heni_deepak’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.