Closed (fixed)
Project:
Page Body Attributes
Version:
1.0.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2022 at 09:19 UTC
Updated:
12 Jan 2023 at 13:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shubham rathore commentedPlease review this patch.
Comment #3
ressaThanks, looks fine! See my comment about one line after project name in #3329932: Missing README.md file.
Comment #4
ressaComment #6
dheeraj jhamtani commentedThanks @ressa all issue fix
Comment #8
ressaThanks, but I think you need to add the changes to this branch?
https://git.drupalcode.org/issue/page_body_attributes-3329924/-/tree/332...
Comment #10
heni_deepak commentedComment #11
Paulo Antonio Vital commentedI will do a review
Comment #12
Paulo Antonio Vital commentedI was able to apply the path #9.
The path was applied very cleanly.
I have all the informations requireds about this module.
Just one thing the instalation section is before requirements section in Drupal coding standards it is wrong.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
Comment #13
Jitendra_Kumar commentedThanks, @Paulo Antonio Vital, I updated patch #2 according to the document.
Please review this patch
Thanks
Comment #14
ressaThanks @Jitendra_Kumar, but any changes should be made to the branch created in #9 by @Dheeraj Jhamtani:
https://git.drupalcode.org/issue/page_body_attributes-3329924/-/tree/332...
For Git access, see https://www.drupal.org/docs/develop/git/setting-up-git-for-drupal/obtain...
After you get Git access, click "Get push access" and you should be able to edit the branch in Gitlab.
Comment #16
Sonal Gyanani commentedComment #17
ressaThanks @Sonal Gyanani, looks good.
Please close MR#2: https://git.drupalcode.org/project/page_body_attributes/-/merge_requests/2
EDIT: I mixed it up, sorry. The creator of MR#2 is @Dheeraj Jhamtani.
Comment #18
anoopsingh92Someone has created an MR!2 against 1.0.x branch.
1.0.x Comparechanges, plain diff MR !2 merge error
We need to close this MR!2 just because this MR is not mergeable and there are no file changes and the second one is MR created directly against main branch 1.0.x.
MR!1 is good to me. We can go ahead with that.
Thank you
Comment #19
anoopsingh92I tried to close this MR @ressa, but I am getting 404 when I close this MR. I think the maintainer can close this MR or creator also close this MR.
Thanks for catching this problem @ressa.
Comment #20
ressa@anoopsingh92: Thanks for the feedback. And you're correct, I believe only the creator (@Dheeraj Jhamtani) of MR#2 can close it, or the maintainer.
Comment #23
heni_deepak commented