Problem/Motivation

Readme.md file missing

Proposed resolution

Readme.md file missing

CommentFileSizeAuthor
#2 3329908-2.patch1.44 KBJitendra_Kumar

Issue fork message_time-3329908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jitendra_Kumar created an issue. See original summary.

Jitendra_Kumar’s picture

Jitendra_Kumar commented
Assigned: Jitendra_Kumar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3329908-2.patch1.44 KB

Please review this patch
Thanks

ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks @Jitendra_Kumar, looks great!

  • How can I install with drush, before running composer command? (change order)
  • Also, code and command should be marked up as code with `.

Perhaps you can create a issue fork (click "Create issue fork") and commit to that, for easier preview and commenting?

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented

@ressa this version
8.x-1.2 do not seems to have git repo initialised.

ressa’s picture

ressa
he/him
commented

@_pratik_ Maybe you need to click "Get push access" and then click "Create new branch"?

heni_deepak’s picture

heni_deepak commented
Version: 8.x-1.2 » 8.0.x-dev

@_pratik_ thanks, i have added dev branch. Please check.

_pratik_ opened merge request !1

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented

Thanks @heni_deepak @ressa,
I pushed local branch and opened merge request. Please review.
Thanks

ressa’s picture

ressa
he/him
commented

Thanks @_pratik_, just two details. And please remember to change Status, after they have been resolved.

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented
Status: Needs work » Needs review
ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Looks better now @_pratik_, perhaps you can change status to "resolved" on Gitlab for these two comments?

I added a new comment about the "Message Time" field.

sourabhjain made their first commit to this issue’s fork.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
ressa’s picture

ressa
he/him
commented
Status: Needs review » Reviewed & tested by the community

Looks fine, thanks!

  • heni_deepak committed 036d5d92 on 8.0.x authored by _pratik_ 
    git commit -m 'Issue #3329908 by _pratik_, Jitendra_Kumar, sourabhjain,...
heni_deepak’s picture

heni_deepak commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.